Skip to content

If no IJsRuntime has been added to Services at render time, add a dummy that will throw if requested #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
egil opened this issue Jan 3, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@egil
Copy link
Member

egil commented Jan 3, 2020

To make it easier for users to discover the JsRuntime Mock and how/when they need it, I think it would be a great solution to register a dummy IJsRuntime just before the service collection gets turned into a service provider. That dummy should simply throw an exception if every instantiated with a descriptive message to the user about providing i IJsRuntime with links to JsRuntimeMock documentation.

@egil egil added enhancement New feature or request good first issue Good for newcomers labels Jan 3, 2020
@egil
Copy link
Member Author

egil commented Jan 22, 2020

Completed by @Siphonophora

@egil egil closed this as completed Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant