-
Notifications
You must be signed in to change notification settings - Fork 41
Add a .once() guard on File module's AJAX uploads to prevent double-uploading #3212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I can confirm that the attached PR fixes the double throbber issue; however, the tests are failing. I can't see which tests are failing. |
I also confirm that the issue with the double throbber is fixed in the PR sandbox. Thanks for filing this ticket and for providing a fix @quicksketch 👍...this has annoyed me oh so many times (my OCD again 😜). The failing tests are pointing to a missing |
@klonos nah; nothing from #3213 is merged yet. It was just a hiccup with the test suite/runners ... I restarted and it is happier now: https://zen.ci/backdrop/backdrop/test/test-php53-backdrop_backdrop_2252-c9c7d06 |
Thanks @serundeputy 👍 ...the php70 test has gone AWOL though. |
@klonos i turned it on and off again and everyone is happy :) backdrop/backdrop#2252 |
@serundeputy don't be fooled ...did you actually expand the "All checks have passed" fieldset and then check the "details" links for php53 and php70? ...as I said, AWOL: ...this bug with zen CI has been happening for a while when you close and reopen a PR: |
this is an expanded one: https://zen.ci/backdrop/backdrop/deploy/deploy-backdrop_backdrop_2252-c9c7d06-2 but i think we are getting off track on this issue; if there are issues with testing you wish to sort out file them and scope them. |
Super, I've merged backdrop/backdrop#2252 into 1.x and 1.10.x. Thank @alexfinnarn and @klonos for reviewing! |
Uh oh!
There was an error while loading. Please reload this page.
Describe your issue or idea
This is a related issue to the double-binding problem we have with AJAX events: #3210
That PR will solve the double-throbber problem in the most common case, but other AJAX events can result in the same double-binding problem for File module.
Steps to reproduce (if reporting a bug)
Actual behavior (if reporting a bug)
Expected behavior (if reporting a bug)
This is actually worse than it looks because the second image is actually uploaded twice, doubling the amount of time it takes to upload on a slow connection.
PR by @quicksketch: backdrop/backdrop#2252
The text was updated successfully, but these errors were encountered: