Skip to content

Documentation is inconsistent #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
UebelAndre opened this issue Jan 26, 2021 · 6 comments
Closed

Documentation is inconsistent #406

UebelAndre opened this issue Jan 26, 2021 · 6 comments
Labels
Can Close? Will close in 30 days if there is no new activity

Comments

@UebelAndre
Copy link
Contributor

🐞 bug report

Description

In trying to use the "experimental"/"modern" rev of this repository in this workspace, I stumbled across some documentation I found to be unclear or incorrect.

  • In Getting Started users are instructed to load and call a deprecated macro pip_repositories
  • It's unclear how to use dependencies loaded from the non-legacy section on Importing pip dependencies
  • It's also not clear what information is in ./docs It appears to be legacy information since the pip documentation is missing pip_install

I think it'd be awesome if someone with context on the current state of the repository could do a refresh on the documentation here 🙏 .

@UebelAndre UebelAndre changed the title Documentation in inconsistent Documentation is inconsistent Jan 26, 2021
@thundergolfer
Copy link

In Getting Started users are instructed to load and call a deprecated macro pip_repositories

Oh yep thanks for pointing this out. Obsolete info.

It's unclear how to use dependencies loaded from the non-legacy section

That detail is in Consuming Pip Dependencies. Do you think that the sections are too separated?

It's also not clear what information is in ./docs

Yeh that folder contained documentation that seemed to be once published to Github pages:

image

I wasn't around when that Github pages site was even working, if it did ever. We've got to sort out the connection between this repo's documentation and the official Bazel documentation. It should be a separate issue.

@UebelAndre
Copy link
Contributor Author

That detail is in Consuming Pip Dependencies. Do you think that the sections are too separated?

No, I just didn't know if that was referring to the legacy way of doing things. I think I was just confused by the layout of the doc

I wasn't around when that Github pages site was even working, if it did ever. We've got to sort out the connection between this repo's documentation and the official Bazel documentation. It should be a separate issue.

Is there a separate issue for that?

@UebelAndre
Copy link
Contributor Author

I would probably opt to remove the "legacy" documentation. It should be there in the versions people are using, right?

@thundergolfer
Copy link

@UebelAndre it looks like the main outstanding item is:

It's unclear how to use dependencies loaded from non-legacy section ...

What action should be taken to close out this issue? Note that the latest README changes are PR'd here: #501

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days.
Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_python!

@github-actions github-actions bot added the Can Close? Will close in 30 days if there is no new activity label Dec 28, 2021
@UebelAndre
Copy link
Contributor Author

The "legacy" documentation was removed in #582 which now covers all my concerns here. Closing this issue out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Can Close? Will close in 30 days if there is no new activity
Projects
None yet
Development

No branches or pull requests

2 participants