From a9e49980ba66205dcdf4f527a778cce7336b795e Mon Sep 17 00:00:00 2001 From: Ido David Date: Wed, 9 Jan 2019 14:03:25 +0200 Subject: [PATCH 1/2] fixed pathencode to support '(' ')' characters --- src/hackney.app.src | 2 +- src/hackney_url.erl | 2 +- test/hackney_url_tests.erl | 4 +++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/hackney.app.src b/src/hackney.app.src index c30cb172..bd88b8f9 100644 --- a/src/hackney.app.src +++ b/src/hackney.app.src @@ -4,7 +4,7 @@ {application, hackney, [ {description, "simple HTTP client"}, - {vsn, "1.15.0"}, + {vsn, "1.15.1"}, {registered, [hackney_pool]}, {applications, [kernel, stdlib, diff --git a/src/hackney_url.erl b/src/hackney_url.erl index 9b95ef15..c5919b34 100644 --- a/src/hackney_url.erl +++ b/src/hackney_url.erl @@ -414,7 +414,7 @@ partial_pathencode(<> = Bin, Acc) -> if C >= $0, C =< $9 -> partial_pathencode(Rest, <>); C >= $A, C =< $Z -> partial_pathencode(Rest, <>); C >= $a, C =< $z -> partial_pathencode(Rest, <>); - C =:= $;; C =:= $=; C =:= $,; C =:= $:; C =:= $@ -> + C =:= $;; C =:= $=; C =:= $,; C =:= $:; C =:= $@; C =:= $(; C =:= $) -> partial_pathencode(Rest, <>); C =:= $.; C =:= $-; C =:= $+; C =:= $~; C =:= $_ -> partial_pathencode(Rest, <>); diff --git a/test/hackney_url_tests.erl b/test/hackney_url_tests.erl index 380aaee2..681aef6c 100644 --- a/test/hackney_url_tests.erl +++ b/test/hackney_url_tests.erl @@ -288,7 +288,9 @@ pathencode_test_() -> {<<"/path1/path2%2fa%2fb">>, <<"/path1/path2%2fa%2fb">>}, {<<"/path1/path2%2test">>, <<"/path1/path2%252test">>}, {<<"/id/name:107/name2;p=1,3">>, <<"/id/name:107/name2;p=1,3">>}, - {<<"/@foobar">>, <<"/@foobar">>} + {<<"/@foobar">>, <<"/@foobar">>}, + {<<"/500x720/filters:quality(75):format(jpg)/spree/product/s/p/spree2018september12picslgzh0650.jpg">>, + <<"/500x720/filters:quality(75):format(jpg)/spree/product/s/p/spree2018september12picslgzh0650.jpg">>} ], [{V, fun() -> R = hackney_url:pathencode(V) end} || {V, R} <- Tests]. From 56034f4eeedc7dbebb03fda69c7cdd114e034dc1 Mon Sep 17 00:00:00 2001 From: idod Date: Tue, 15 Jan 2019 17:09:17 +0200 Subject: [PATCH 2/2] revert version change --- src/hackney.app.src | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hackney.app.src b/src/hackney.app.src index bd88b8f9..c30cb172 100644 --- a/src/hackney.app.src +++ b/src/hackney.app.src @@ -4,7 +4,7 @@ {application, hackney, [ {description, "simple HTTP client"}, - {vsn, "1.15.1"}, + {vsn, "1.15.0"}, {registered, [hackney_pool]}, {applications, [kernel, stdlib,