Skip to content

[Electron] Random crash on quit 'Electron'. #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benoitlahoz opened this issue Jan 31, 2025 · 1 comment
Closed

[Electron] Random crash on quit 'Electron'. #10

benoitlahoz opened this issue Jan 31, 2025 · 1 comment
Labels
bug Something isn't working electron Concerns 'Electron' usage.

Comments

@benoitlahoz
Copy link
Owner

When quitting Electron example, have this random crash, like the one stated in this issue of node-addon-api.

It looks like the FrameEventListener of the OpenGLClient is not disposed correctly (e.g. before actually quitting).

FATAL ERROR: Error::Error napi_define_properties
----- Native stack trace -----

 1: 0x123bd78c7 node::OnFatalError(char const*, char const*) [[MY_PATH]/node-syphon/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
 2: 0x123b76bad napi_fatal_error [[MY_PATH]/node-syphon/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
 3: 0x10d712b6a Napi::Error::Fatal(char const*, char const*) [[MY_PATH]/node-syphon/packages/lib/dist/bin/syphon.node]
 4: 0x10d713804 Napi::Error::Error(napi_env__*, napi_value__*) [[MY_PATH]/node-syphon/packages/lib/dist/bin/syphon.node]
 5: 0x10d713681 Napi::Error::New(napi_env__*) [[MY_PATH]/node-syphon/packages/lib/dist/bin/syphon.node]
 6: 0x10d721fda Napi::Function::Call(std::initializer_list<napi_value__*> const&) const [[MY_PATH]/node-syphon/packages/lib/dist/bin/syphon.node]
 7: 0x10d722292 std::__1::__function::__func<syphon::FrameEventListener::Call(unsigned char*, unsigned long, unsigned long)::$_0, std::__1::allocator<syphon::FrameEventListener::Call(unsigned char*, unsigned long, unsigned long)::$_0>, void (Napi::Env, Napi::Function)>::operator()(Napi::Env&&, Napi::Function&&) [[MY_PATH]/node-syphon/packages/lib/dist/bin/syphon.node]
 8: 0x10d721ea5 Napi::ThreadSafeFunction::CallJS(napi_env__*, napi_value__*, void*, void*) [[MY_PATH]/node-syphon/packages/lib/dist/bin/syphon.node]
 9: 0x123b7a69a node_api_get_module_file_name [[MY_PATH]/node-syphon/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
10: 0x11bb25ae7 uv_async_send [[MY_PATH]/node-syphon/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
11: 0x11bb37c8d uv_free_interface_addresses [[MY_PATH]/node-syphon/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
12: 0x11bb26065 uv_run [[MY_PATH]/node-syphon/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
13: 0x123af3c60 node::MakeCallback(v8::Isolate*, v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*) [[MY_PATH]/node-syphon/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
14: 0x123cd1564 node::PromiseRejectCallback(v8::PromiseRejectMessage) [[MY_PATH]/node-syphon/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
15: 0x123cd6332 node::PromiseRejectCallback(v8::PromiseRejectMessage) [[MY_PATH]/node-syphon/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
16: 0x7ff80faaf4e1 _pthread_start [/usr/lib/system/libsystem_pthread.dylib]
17: 0x7ff80faaaf6b thread_start [/usr/lib/system/libsystem_pthread.dylib]
@benoitlahoz benoitlahoz changed the title Random crash on quit 'Electron'. [Electron] Random crash on quit 'Electron'. Feb 23, 2025
@benoitlahoz benoitlahoz added electron Concerns 'Electron' usage. bug Something isn't working labels Feb 23, 2025
@benoitlahoz
Copy link
Owner Author

Fixed with v1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working electron Concerns 'Electron' usage.
Projects
None yet
Development

No branches or pull requests

1 participant