Skip to content

Commit 052799e

Browse files
committed
Commits
1 parent b339b1f commit 052799e

File tree

2 files changed

+25
-0
lines changed

2 files changed

+25
-0
lines changed

README.md

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,7 @@ align="right" width="20%" height="auto"/>
164164
* [Reusing this project](#reusing-this-project)
165165
* [Contributing](#contributing)
166166
* [You and your project](#you-and-your-project)
167+
* [Commits](#commits)
167168
* [Getting your project started](#getting-your-project-started)
168169
* [The JDK](#the-jdk)
169170
* [Use Gradle or Maven](#use-gradle-or-maven)
@@ -351,6 +352,30 @@ I'd love a conversation with you.
351352

352353
---
353354

355+
## Commits
356+
357+
Have you looked at a PR on a project that long, complex, and touched many
358+
files?
359+
I'm not a fan of reviewing these, and I suspect you aren't either.
360+
361+
For projects I'm on, I want commits like this:
362+
- **Small** — I can carry context in my head, and understand the change
363+
- A good commit message — should:
364+
- Follow standard Git recommendations.
365+
One of many examples is from [Toni Cardina
366+
Bardos](https://gist.github.com/tonibardina/9290fbc7d605b4f86919426e614fe692)
367+
who summarizes common advice.
368+
See the [official Git
369+
documentation](https://git-scm.com/docs/git-commit#_discussion).
370+
This is a good discussion with contributors to your project
371+
- Be sensible for others
372+
<a href="https://xkcd.com/1296/">
373+
<img src="./images/git_commit.svg" alt="Git Commit" align="center" width="20%" height="auto"/>
374+
</a>
375+
- Be able to easily check the build pipeline for _every_ commit
376+
377+
---
378+
354379
<!-- TODO: Should this section be moved or removed? It is awkward here -->
355380
## You and your project
356381

images/git_commit.png

52.5 KB
Loading

0 commit comments

Comments
 (0)