Skip to content

Esplora blockchain fails reorg test #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LLFourn opened this issue May 31, 2021 · 9 comments
Closed

Esplora blockchain fails reorg test #357

LLFourn opened this issue May 31, 2021 · 9 comments
Labels

Comments

@LLFourn
Copy link
Contributor

LLFourn commented May 31, 2021

see:

#[cfg(not(feature = "esplora"))]

Close this issue by getting to the bottom of it and making it pass.

@gabbyprecious
Copy link

Hello @LLFourn is this still available?

@LLFourn
Copy link
Contributor Author

LLFourn commented Feb 26, 2022

Yep this is still a problem -- that line of code is still there.

@notmandatory
Copy link
Member

@gabbyprecious would you rather work on this one or #518? I'd rather new folks take one issue at a time.

@Gioelio
Copy link

Gioelio commented Mar 8, 2022

Hi, i came from summerofbitcoin and if this issue is still available i can try to fix it

@notmandatory
Copy link
Member

Hi @Gioelio do you still want to work on this issue or did you take another summer of bitcoin project?

@Gioelio
Copy link

Gioelio commented May 4, 2022

I tried to fix it but I didn't understand what the problem was, sorry

@w3irdrobot
Copy link

I have some time today to work on this. I can tackle this one if no one else is already doing it.

@notmandatory
Copy link
Member

FYI I've done some research on how electrum reacts to reorgs and I think it could be related to why this and the electrum (with version 0.9.1) integration tests fail. See here: https://bitcoin.stackexchange.com/questions/114044/how-can-i-simulate-a-reorg-for-testing

@notmandatory
Copy link
Member

New bdk_chain crate handles reorgs independent of where the block data comes from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants