Upgrade fcm-notifications to ES2017 syntax

Author: nicolasgarnier

fcm-notifications/functions/.eslintrc.json

@@ -1,7 +1,7 @@
 {
   "parserOptions": {
     // Required for certain syntax usages
-    "ecmaVersion": 6
+    "ecmaVersion": 2017
   },
   "plugins": [
     "promise"

fcm-notifications/functions/index.js

@@ -26,7 +26,7 @@ admin.initializeApp();
  * Users save their device notification tokens to `/users/{followedUid}/notificationTokens/{notificationToken}`.
  */
 exports.sendFollowerNotification = functions.database.ref('/followers/{followedUid}/{followerUid}')
-    .onWrite((change, context) => {
+    .onWrite(async (change, context) => {
       const followerUid = context.params.followerUid;
       const followedUid = context.params.followedUid;
       // If un-follow we exit the function.
@@ -48,44 +48,42 @@ exports.sendFollowerNotification = functions.database.ref('/followers/{followedU
       // The array containing all the user's tokens.
       let tokens;
 
-      return Promise.all([getDeviceTokensPromise, getFollowerProfilePromise]).then(results => {
-        tokensSnapshot = results[0];
-        const follower = results[1];
+      const results = await Promise.all([getDeviceTokensPromise, getFollowerProfilePromise]);
+      tokensSnapshot = results[0];
+      const follower = results[1];
 
-        // Check if there are any device tokens.
-        if (!tokensSnapshot.hasChildren()) {
-          return console.log('There are no notification tokens to send to.');
-        }
-        console.log('There are', tokensSnapshot.numChildren(), 'tokens to send notifications to.');
-        console.log('Fetched follower profile', follower);
+      // Check if there are any device tokens.
+      if (!tokensSnapshot.hasChildren()) {
+        return console.log('There are no notification tokens to send to.');
+      }
+      console.log('There are', tokensSnapshot.numChildren(), 'tokens to send notifications to.');
+      console.log('Fetched follower profile', follower);
 
-        // Notification details.
-        const payload = {
-          notification: {
-            title: 'You have a new follower!',
-            body: `${follower.displayName} is now following you.`,
-            icon: follower.photoURL
-          }
-        };
+      // Notification details.
+      const payload = {
+        notification: {
+          title: 'You have a new follower!',
+          body: `${follower.displayName} is now following you.`,
+          icon: follower.photoURL
+        }
+      };
 
-        // Listing all tokens as an array.
-        tokens = Object.keys(tokensSnapshot.val());
-        // Send notifications to all tokens.
-        return admin.messaging().sendToDevice(tokens, payload);
-      }).then((response) => {
-        // For each message check if there was an error.
-        const tokensToRemove = [];
-        response.results.forEach((result, index) => {
-          const error = result.error;
-          if (error) {
-            console.error('Failure sending notification to', tokens[index], error);
-            // Cleanup the tokens who are not registered anymore.
-            if (error.code === 'messaging/invalid-registration-token' ||
-                error.code === 'messaging/registration-token-not-registered') {
-              tokensToRemove.push(tokensSnapshot.ref.child(tokens[index]).remove());
-            }
+      // Listing all tokens as an array.
+      tokens = Object.keys(tokensSnapshot.val());
+      // Send notifications to all tokens.
+      const response = await admin.messaging().sendToDevice(tokens, payload);
+      // For each message check if there was an error.
+      const tokensToRemove = [];
+      response.results.forEach((result, index) => {
+        const error = result.error;
+        if (error) {
+          console.error('Failure sending notification to', tokens[index], error);
+          // Cleanup the tokens who are not registered anymore.
+          if (error.code === 'messaging/invalid-registration-token' ||
+              error.code === 'messaging/registration-token-not-registered') {
+            tokensToRemove.push(tokensSnapshot.ref.child(tokens[index]).remove());
           }
-        });
-        return Promise.all(tokensToRemove);
+        }
       });
+      return Promise.all(tokensToRemove);
     });

fcm-notifications/functions/package.json

@@ -17,5 +17,8 @@
     "deploy": "firebase deploy --only functions",
     "logs": "firebase functions:log"
   },
+  "engines": {
+    "node": "8"
+  },
   "private": true
 }