Skip to content

Commit d9ad5e8

Browse files
authored
Fix missing features (#436)
## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective These crates had some missing features, which caused compilation errors when trying to run the tests from VSCode. The reason that CI kept building was that rust unifies all the workspace features, so as long as one crate has them enabled it's fine. On the other hand, when running a test from VSCode, it will only have that crates features in mind. Note that the uniffi feature of core requires internal because of these two types: https://github.com/bitwarden/sdk-internal/blob/main/crates/bitwarden-core/src/uniffi_support.rs#L30-L42 ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes
1 parent 1e3b4ba commit d9ad5e8

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

crates/bitwarden-core/Cargo.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,13 @@ no-memory-hardening = [
2121
] # Disable memory hardening features
2222
secrets = [] # Secrets manager API
2323
uniffi = [
24+
"internal",
2425
"bitwarden-crypto/uniffi",
2526
"bitwarden-encoding/uniffi",
2627
"dep:uniffi"
2728
] # Uniffi bindings
2829
wasm = [
30+
"bitwarden-encoding/wasm",
2931
"bitwarden-error/wasm",
3032
"dep:wasm-bindgen",
3133
"dep:wasm-bindgen-futures",

crates/bitwarden-vault/Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ keywords.workspace = true
1616

1717
[features]
1818
uniffi = [
19+
"bitwarden-collections/uniffi",
1920
"bitwarden-core/uniffi",
2021
"bitwarden-crypto/uniffi",
2122
"dep:uniffi"

0 commit comments

Comments
 (0)