Skip to content
This repository was archived by the owner on May 31, 2019. It is now read-only.

Commit 488de2b

Browse files
hujiajiehferreiro
authored andcommitted
buffer: remove a wrongly added attribute specifier
It doesn't seem to make much sense to have the mentioned typedef declaration equipped with NODE_EXTERN. In fact, when compiling with GCC, an attribute specifier like __attribute__((visibility("default"))) in such a typedef declaration will cause the following warning message: warning: ‘visibility’ attribute ignored [-Wattributes] The issue goes unnoticed because NODE_EXTERN is defined as nothing for GCC builds, but for correctness it's better to not specify it here at all. PR-URL: nodejs/node#14466 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
1 parent 764ca2f commit 488de2b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/node_buffer.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ NODE_EXTERN void SetArrayBufferCreator(
2323
static const unsigned int kMaxLength =
2424
sizeof(int32_t) == sizeof(intptr_t) ? 0x3fffffff : 0x7fffffff;
2525

26-
NODE_EXTERN typedef void (*FreeCallback)(char* data, void* hint);
26+
typedef void (*FreeCallback)(char* data, void* hint);
2727

2828
NODE_EXTERN bool HasInstance(v8::Local<v8::Value> val);
2929
NODE_EXTERN bool HasInstance(v8::Local<v8::Object> val);

0 commit comments

Comments
 (0)