feat: new rule tag-line; fixes gajus#93

Author: brettz9

.README/README.md

@@ -581,4 +581,5 @@ selector).
 {"gitdown": "include", "file": "./rules/require-throws.md"}
 {"gitdown": "include", "file": "./rules/require-yields.md"}
 {"gitdown": "include", "file": "./rules/require-yields-check.md"}
+{"gitdown": "include", "file": "./rules/tag-lines.md"}
 {"gitdown": "include", "file": "./rules/valid-types.md"}

.README/rules/tag-lines.md

@@ -0,0 +1,28 @@
+### `tag-lines`
+
+Enforces lines (or no lines) between tags.
+
+#### Options
+
+The first option is a single string set to "always" or "never" (defaults to
+"never").
+
+The second option is an object with the following optional properties.
+
+##### `count` (defaults to 1)
+
+Use with "always" to indicate the number of lines to require be present.
+
+##### `noEndLine` (defaults to `false`)
+
+Use with "always" to indicate tag lines should not be added at the end.
+
+|||
+|---|---|
+|Context|everywhere|
+|Tags|Any|
+|Recommended|false|
+|Settings|N/A|
+|Options|(a string matching `"always" or "never"` and optional object with `count` and `noEndLine`)|
+
+<!-- assertions tagLines -->

README.md

@@ -67,6 +67,7 @@ JSDoc linting rules for ESLint.
         * [`require-throws`](#eslint-plugin-jsdoc-rules-require-throws)
         * [`require-yields`](#eslint-plugin-jsdoc-rules-require-yields)
         * [`require-yields-check`](#eslint-plugin-jsdoc-rules-require-yields-check)
+        * [`tag-lines`](#eslint-plugin-jsdoc-rules-tag-lines)
         * [`valid-types`](#eslint-plugin-jsdoc-rules-valid-types)
 
 
@@ -18230,6 +18231,156 @@ function * quux (foo) {
 ````
 
 
+<a name="eslint-plugin-jsdoc-rules-tag-lines"></a>
+### <code>tag-lines</code>
+
+Enforces lines (or no lines) between tags.
+
+<a name="eslint-plugin-jsdoc-rules-tag-lines-options-37"></a>
+#### Options
+
+The first option is a single string set to "always" or "never" (defaults to
+"never").
+
+The second option is an object with the following optional properties.
+
+<a name="eslint-plugin-jsdoc-rules-tag-lines-options-37-count-defaults-to-1"></a>
+##### <code>count</code> (defaults to 1)
+
+Use with "always" to indicate the number of lines to require be present.
+
+<a name="eslint-plugin-jsdoc-rules-tag-lines-options-37-noendline-defaults-to-false"></a>
+##### <code>noEndLine</code> (defaults to <code>false</code>)
+
+Use with "always" to indicate tag lines should not be added at the end.
+
+|||
+|---|---|
+|Context|everywhere|
+|Tags|Any|
+|Recommended|false|
+|Settings|N/A|
+|Options|(a string matching `"always" or "never"` and optional object with `count` and `noEndLine`)|
+
+The following patterns are considered problems:
+
+````js
+/**
+ * Some description
+ * @param {string} a
+ * @param {number} b
+ */
+// "jsdoc/tag-lines": ["error"|"warn", "always"]
+// Message: Expected 1 line between tags but found 0
+
+/**
+ * Some description
+ * @param {string} a
+ * @param {number} b
+ */
+// "jsdoc/tag-lines": ["error"|"warn", "always",{"count":2}]
+// Message: Expected 2 lines between tags but found 0
+
+/**
+ * Some description
+ * @param {string} a
+ *
+ * @param {number} b
+ */
+// "jsdoc/tag-lines": ["error"|"warn", "always",{"count":2}]
+// Message: Expected 2 lines between tags but found 1
+
+/**
+ * Some description
+ * @param {string} a
+ * @param {number} b
+ */
+// "jsdoc/tag-lines": ["error"|"warn", "always",{"noEndLine":true}]
+// Message: Expected 1 line between tags but found 0
+
+/**
+ * Some description
+ * @param {string} a
+ *
+ * @param {number} b
+ *
+ */
+// "jsdoc/tag-lines": ["error"|"warn", "never"]
+// Message: Expected no lines between tags
+
+/**
+ * Some description
+ * @param {string} a
+ *
+ * @param {number} b
+ *
+ */
+// Message: Expected no lines between tags
+
+/**
+ * Some description
+ * @param {string} a
+ *
+ * @param {number} b
+ * @param {number} c
+ */
+// "jsdoc/tag-lines": ["error"|"warn", "always"]
+// Message: Expected 1 line between tags but found 0
+````
+
+The following patterns are not considered problems:
+
+````js
+/**
+ * Some description
+ * @param {string} a
+ * @param {number} b
+ */
+
+/**
+ * Some description
+ * @param {string} a
+ * @param {number} b
+ */
+// "jsdoc/tag-lines": ["error"|"warn", "never"]
+
+/**
+ * @param {string} a
+ *
+ * @param {string} a
+ */
+// "jsdoc/tag-lines": ["error"|"warn", "always",{"noEndLine":true}]
+
+/**
+ * @param {string} a
+ */
+// "jsdoc/tag-lines": ["error"|"warn", "never",{"noEndLine":true}]
+
+/** @param {number} b */
+// "jsdoc/tag-lines": ["error"|"warn", "never",{"noEndLine":true}]
+
+/**
+ * Some description
+ * @param {string} a
+ *
+ * @param {number} b
+ *
+ */
+// "jsdoc/tag-lines": ["error"|"warn", "always"]
+
+/**
+ * Some description
+ * @param {string} a
+ *
+ *
+ * @param {number} b
+ *
+ *
+ */
+// "jsdoc/tag-lines": ["error"|"warn", "always",{"count":2}]
+````
+
+
 <a name="eslint-plugin-jsdoc-rules-valid-types"></a>
 ### <code>valid-types</code>
 
@@ -18310,7 +18461,7 @@ for valid types (based on the tag's `type` value), and either portion checked
 for presence (based on `false` `name` or `type` values or their `required`
 value). See the setting for more details.
 
-<a name="eslint-plugin-jsdoc-rules-valid-types-options-37"></a>
+<a name="eslint-plugin-jsdoc-rules-valid-types-options-38"></a>
 #### Options
 
 - `allowEmptyNamepaths` (default: true) - Set to `false` to bulk disallow

src/index.js

@@ -41,6 +41,7 @@ import requireReturnsType from './rules/requireReturnsType';
 import requireThrows from './rules/requireThrows';
 import requireYields from './rules/requireYields';
 import requireYieldsCheck from './rules/requireYieldsCheck';
+import tagLines from './rules/tagLines';
 import validTypes from './rules/validTypes';
 
 export default {
@@ -91,6 +92,7 @@ export default {
         'jsdoc/require-throws': 'off',
         'jsdoc/require-yields': 'warn',
         'jsdoc/require-yields-check': 'warn',
+        'jsdoc/tag-lines': 'warn',
         'jsdoc/valid-types': 'warn',
       },
     },
@@ -139,6 +141,7 @@ export default {
     'require-throws': requireThrows,
     'require-yields': requireYields,
     'require-yields-check': requireYieldsCheck,
+    'tag-lines': tagLines,
     'valid-types': validTypes,
   },
 };

src/iterateJsdoc.js

@@ -184,7 +184,11 @@ const getUtils = (
     }];
   };
 
-  utils.removeTag = (tagIndex) => {
+  utils.removeTag = (idx) => {
+    return utils.removeTagItem(idx);
+  };
+
+  utils.removeTagItem = (tagIndex, tagSourceOffset = 0) => {
     const {source: tagSource} = jsdoc.tags[tagIndex];
     let lastIndex;
     const firstNumber = jsdoc.source[0].number;
@@ -206,7 +210,8 @@ const getUtils = (
 
           return true;
         });
-        jsdoc.source.splice(sourceIndex, spliceCount);
+        jsdoc.source.splice(sourceIndex + tagSourceOffset, spliceCount - tagSourceOffset);
+        tagSource.splice(tagIdx + tagSourceOffset, spliceCount - tagSourceOffset);
         lastIndex = sourceIndex;
 
         return true;
@@ -237,6 +242,48 @@ const getUtils = (
     });
   };
 
+  utils.addLines = (tagIndex, tagSourceOffset, numLines) => {
+    const {source: tagSource} = jsdoc.tags[tagIndex];
+    let lastIndex;
+    const firstNumber = jsdoc.source[0].number;
+    tagSource.some(({number}) => {
+      const makeLine = () => {
+        return {
+          number,
+          source: '',
+          tokens: seedTokens({
+            delimiter: '*',
+            start: indent + ' ',
+          }),
+        };
+      };
+      const makeLines = () => {
+        return Array.from({length: numLines}, makeLine);
+      };
+      const sourceIndex = jsdoc.source.findIndex(({
+        number: srcNumber, tokens: {end},
+      }) => {
+        return number === srcNumber && !end;
+      });
+      // istanbul ignore else
+      if (sourceIndex > -1) {
+        const lines = makeLines();
+        jsdoc.source.splice(sourceIndex + tagSourceOffset, 0, ...lines);
+
+        // tagSource.splice(tagIdx + 1, 0, ...makeLines());
+        lastIndex = sourceIndex;
+
+        return true;
+      }
+
+      // istanbul ignore next
+      return false;
+    });
+    jsdoc.source.slice(lastIndex).forEach((src, idx) => {
+      src.number = firstNumber + lastIndex + idx;
+    });
+  };
+
   utils.flattenRoots = (params) => {
     return jsdocUtils.flattenRoots(params);
   };

src/rules/tagLines.js

@@ -0,0 +1,92 @@
+import iterateJsdoc from '../iterateJsdoc';
+
+export default iterateJsdoc(({
+  context,
+  jsdoc,
+  utils,
+}) => {
+  const [
+    alwaysNever = 'never',
+    {
+      count = 1,
+      noEndLine = false,
+    } = {},
+  ] = context.options;
+
+  if (alwaysNever === 'never') {
+    jsdoc.tags.some((tg, tagIdx) => {
+      return tg.source.some(({tokens: {tag, name, type, description, end}}, idx) => {
+        const fixer = () => {
+          utils.removeTagItem(tagIdx, idx);
+        };
+        if (!tag && !name && !type && !description && !end) {
+          utils.reportJSDoc(
+            'Expected no lines between tags',
+            {line: tg.source[0].number + 1},
+            fixer,
+            true,
+          );
+
+          return true;
+        }
+
+        return false;
+      });
+    });
+
+    return;
+  }
+
+  (noEndLine ? jsdoc.tags.slice(0, -1) : jsdoc.tags).some((tg, tagIdx) => {
+    const lines = [];
+
+    tg.source.forEach(({number, tokens: {tag, name, type, description, end}}, idx) => {
+      if (!tag && !name && !type && !description && !end) {
+        lines.push({idx, number});
+      }
+    });
+    if (lines.length < count) {
+      const fixer = () => {
+        utils.addLines(tagIdx, lines[lines.length - 1]?.idx || 1, count - lines.length);
+      };
+      utils.reportJSDoc(
+        `Expected ${count} line${count === 1 ? '' : 's'} between tags but found ${lines.length}`,
+        {line: lines[lines.length - 1]?.number || tg.source[0].number},
+        fixer,
+        true,
+      );
+
+      return true;
+    }
+
+    return false;
+  });
+}, {
+  iterateAllJsdocs: true,
+  meta: {
+    docs: {
+      description: 'Enforces lines (or no lines) between tags.',
+      url: 'https://github.com/gajus/eslint-plugin-jsdoc#eslint-plugin-jsdoc-rules-tag-lines',
+    },
+    fixable: true,
+    schema: [
+      {
+        enum: ['always', 'never'],
+        type: 'string',
+      },
+      {
+        additionalProperies: false,
+        properties: {
+          count: {
+            type: 'integer',
+          },
+          noEndLine: {
+            type: 'boolean',
+          },
+        },
+        type: 'object',
+      },
+    ],
+    type: 'suggestion',
+  },
+});