Using hostaddr will cache the DNS lookup

mjgp2 · mjgp2 · commit 4f4c27aecd9b · 2022-05-03T18:27:51.000+01:00
"If host is specified without hostaddr, a host name lookup occurs." https://www.postgresql.org/docs/8.1/libpq.html#LIBPQ-CONNECT
diff --git a/packages/pg/lib/connection-parameters.js b/packages/pg/lib/connection-parameters.js
@@ -155,11 +155,7 @@ class ConnectionParameters {
     if (this.client_encoding) {
       params.push('client_encoding=' + quoteParamValue(this.client_encoding))
     }
-    dns.lookup(this.host, function (err, address) {
-      if (err) return cb(err, null)
-      params.push('hostaddr=' + quoteParamValue(address))
-      return cb(null, params.join(' '))
-    })
+    return cb(null, params.join(' '))
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -155,11 +155,7 @@ class ConnectionParameters {`
`155`	`155`	`if (this.client_encoding) {`
`156`	`156`	`params.push('client_encoding=' + quoteParamValue(this.client_encoding))`
`157`	`157`	`}`
`158`		`- dns.lookup(this.host, function (err, address) {`
`159`		`- if (err) return cb(err, null)`
`160`		`- params.push('hostaddr=' + quoteParamValue(address))`
`161`		`- return cb(null, params.join(' '))`
`162`		`- })`
	`158`	`+ return cb(null, params.join(' '))`
`163`	`159`	`}`
`164`	`160`	`}`
`165`	`161`