From 57da3db8de7fe942c466505b5f82b42179238764 Mon Sep 17 00:00:00 2001 From: Jun Aruga Date: Wed, 21 Dec 2022 18:57:17 +0100 Subject: [PATCH] CI: Drop allow-failure option in some Ubuntu cases. As we fixed some of the issues, we can drop the allow-failure option in some cases. --- .github/workflows/build.yml | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 34cc9bbd..2660229e 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -29,12 +29,10 @@ jobs: include: # Comment out due to ci/setup.sh stucking. # - {os: ubuntu-18.04, ruby: 2.4, db: mariadb10.1} - # Allow failure due to the issue #965, #1165. - - {os: ubuntu-20.04, ruby: '2.4', db: mariadb10.3, allow-failure: true} + - {os: ubuntu-20.04, ruby: '2.4', db: mariadb10.3} - {os: ubuntu-18.04, ruby: '2.4', db: mysql57} - # Allow failure due to the issue #1165. - - {os: ubuntu-20.04, ruby: '2.4', db: mysql80, allow-failure: true} - - {os: ubuntu-18.04, ruby: 'head', db: '', allow-failure: true} + - {os: ubuntu-20.04, ruby: '2.4', db: mysql80} + - {os: ubuntu-18.04, ruby: 'head', db: ''} # db: A DB's brew package name in macOS case. # Set a name "db: 'name@X.Y'" when using an old version. # MariaDB lastet version @@ -42,7 +40,7 @@ jobs: # https://github.com/brianmario/mysql2/issues/1194 - {os: macos-latest, ruby: '2.6', db: mariadb, allow-failure: true} # MySQL latest version - # Allow failure due to the issue #1165. + # Allow failure due to the issue #1194. - {os: macos-latest, ruby: '2.6', db: mysql, allow-failure: true} # On the fail-fast: true, it cancels all in-progress jobs # if any matrix job fails unlike Travis fast_finish.