Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: browserify/browserify-sign
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.0.4
Choose a base ref
...
head repository: browserify/browserify-sign
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.2.2
Choose a head ref

Commits on Jan 3, 2018

  1. [Tests] log when openssl doesn't support cipher

    This fixes #37.
    kapouer authored and ljharb committed Jan 3, 2018

    Verified

    This commit was signed with the committer’s verified signature.
    parlough Parker Lougheed
    Copy the full SHA
    5f6fb17 View commit details

Commits on May 5, 2020

  1. update deps, modernise usage, use readable-stream (#49)

    * use readable-stream instead of bare stream
    
    * update deps, fix most lint errors
    
    * switch from `new Buffer()` and require 'buffer' explicitly
    
    * only test signature algorithms supported by current Node.js
    
    * update travis for current Node.js versions
    rvagg authored May 5, 2020
    1

    Verified

    This commit was signed with the committer’s verified signature.
    parlough Parker Lougheed
    Copy the full SHA
    92b2b83 View commit details
  2. 4.1.0

    calvinmetcalf committed May 5, 2020
    Copy the full SHA
    aa6a963 View commit details

Commits on May 18, 2020

  1. Copy the full SHA
    8ccadda View commit details
  2. 4.2.0

    calvinmetcalf committed May 18, 2020
    Copy the full SHA
    eeb0c1e View commit details

Commits on Aug 4, 2020

  1. bump elliptic (#58)

    * bump elliptic
    
    * update package-lock
    calvinmetcalf authored Aug 4, 2020
    Copy the full SHA
    ecbcf3d View commit details
  2. 4.2.1

    calvinmetcalf committed Aug 4, 2020
    1
    Copy the full SHA
    266b780 View commit details

Commits on Sep 18, 2023

  1. Copy the full SHA
    09a8995 View commit details
  2. Copy the full SHA
    cc5350b View commit details
  3. [Deps] update bn.js, browserify-rsa, elliptic, parse-asn1, `r…

    …eadable-stream`, `safe-buffer`
    ljharb committed Sep 18, 2023
    Copy the full SHA
    a67d0eb View commit details
  4. [eslint] switch to eslint

    ljharb committed Sep 18, 2023
    Copy the full SHA
    83fe463 View commit details
  5. Copy the full SHA
    75ce1d5 View commit details
  6. [Dev Deps] fix eslint range

    ljharb committed Sep 18, 2023
    Copy the full SHA
    98d4e0d View commit details
  7. [Tests] add npm run posttest

    ljharb committed Sep 18, 2023
    Copy the full SHA
    75dd8fd View commit details
  8. Copy the full SHA
    3aa43cf View commit details
  9. [Tests] skip unsupported schemes

    without this, id crashes in node 17
    ljharb committed Sep 18, 2023
    Copy the full SHA
    703c83e View commit details
  10. Copy the full SHA
    d845d85 View commit details
  11. [Tests] handle openSSL not supporting a scheme

    Technique from #38; see #37
    ljharb committed Sep 18, 2023
    Copy the full SHA
    f5f17c2 View commit details
  12. [Fix] sign: throw on unsupported padding scheme

    Do not silently apply the wrong padding scheme.
    btj authored and ljharb committed Sep 18, 2023
    Copy the full SHA
    8767739 View commit details

Commits on Sep 20, 2023

  1. Copy the full SHA
    4418183 View commit details
  2. [meta] add safe-publish-latest

    ljharb committed Sep 20, 2023
    Copy the full SHA
    dcf49ce View commit details
  3. Copy the full SHA
    9ac5a5e View commit details

Commits on Oct 21, 2023

  1. [Fix] properly check the upper bound for DSA signatures

    Co-authored-by: roadicing <roadicing@gmail.com>
    Co-authored-by: Jordan Harband <ljharb@gmail.com>
    roadicing and ljharb committed Oct 21, 2023
    Copy the full SHA
    85994cd View commit details

Commits on Oct 25, 2023

  1. [Dev Deps] update tape

    ljharb committed Oct 25, 2023
    Copy the full SHA
    3aec038 View commit details
  2. v4.2.2

    ljharb committed Oct 25, 2023
    Copy the full SHA
    4af5a90 View commit details
Showing with 923 additions and 368 deletions.
  1. +50 −0 .eslintrc
  2. +12 −0 .github/FUNDING.yml
  3. +18 −0 .github/workflows/node-aught.yml
  4. +7 −0 .github/workflows/node-pretest.yml
  5. +18 −0 .github/workflows/node-tens.yml
  6. +9 −0 .github/workflows/rebase.yml
  7. +12 −0 .github/workflows/require-allow-edits.yml
  8. +8 −0 .gitignore
  9. +3 −0 .npmrc
  10. +0 −16 .travis.yml
  11. +303 −0 CHANGELOG.md
  12. +3 −1 algos.js
  13. +62 −61 browser/index.js
  14. +108 −103 browser/sign.js
  15. +59 −56 browser/verify.js
  16. +7 −5 index.js
  17. +69 −38 package.json
  18. +175 −88 test/index.js
50 changes: 50 additions & 0 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
{
"root": true,

"extends": "@ljharb",

"rules": {
"func-style": "warn",
"indent": ["error", 2],
"multiline-comment-style": "off",
"sort-keys": "off",
},

"overrides": [
{
"files": "browser/index.js",
"rules": {
"func-name-matching": "off",
"max-statements-per-line": "off",
"no-underscore-dangle": "warn",
},
},
{
"files": "browser/verify.js",
"rules": {
"max-params": "off",
"max-statements": "off",
"max-statements-per-line": "off",
"no-param-reassign": "warn",
"no-plusplus": "warn",
"no-use-before-define": "warn",
}
},
{
"files": "browser/sign.js",
"rules": {
"max-params": "off",
"max-statements-per-line": "off",
"no-param-reassign": "warn",
"no-plusplus": "warn",
"no-use-before-define": "warn",
}
},
{
"files": "test/*.js",
"rules": {
"max-lines-per-function": "off",
},
},
],
}
12 changes: 12 additions & 0 deletions .github/FUNDING.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# These are supported funding model platforms

github: [ljharb]
patreon: # Replace with a single Patreon username
open_collective: # Replace with a single Open Collective username
ko_fi: # Replace with a single Ko-fi username
tidelift: npm/browserify-sign
community_bridge: # Replace with a single Community Bridge project-name e.g., cloud-foundry
liberapay: # Replace with a single Liberapay username
issuehunt: # Replace with a single IssueHunt username
otechie: # Replace with a single Otechie username
custom: # Replace with up to 4 custom sponsorship URLs e.g., ['link1', 'link2']
18 changes: 18 additions & 0 deletions .github/workflows/node-aught.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
name: 'Tests: node.js 4 - 10'

on: [pull_request, push]

jobs:
tests:
uses: ljharb/actions/.github/workflows/node.yml@main
with:
range: '>= 4 < 10'
type: minors
command: npm run tests-only

node:
name: 'node 4 - 10'
needs: [tests]
runs-on: ubuntu-latest
steps:
- run: 'echo tests completed'
7 changes: 7 additions & 0 deletions .github/workflows/node-pretest.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
name: 'Tests: pretest/posttest'

on: [pull_request, push]

jobs:
tests:
uses: ljharb/actions/.github/workflows/pretest.yml@main
18 changes: 18 additions & 0 deletions .github/workflows/node-tens.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
name: 'Tests: node.js >= 10'

on: [pull_request, push]

jobs:
tests:
uses: ljharb/actions/.github/workflows/node.yml@main
with:
range: '>= 10'
type: minors
command: npm run tests-only

node:
name: 'node >= 10'
needs: [tests]
runs-on: ubuntu-latest
steps:
- run: 'echo tests completed'
9 changes: 9 additions & 0 deletions .github/workflows/rebase.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
name: Automatic Rebase

on: [pull_request_target]

jobs:
_:
uses: ljharb/actions/.github/workflows/rebase.yml@main
secrets:
token: ${{ secrets.GITHUB_TOKEN }}
12 changes: 12 additions & 0 deletions .github/workflows/require-allow-edits.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
name: Require “Allow Edits”

on: [pull_request_target]

jobs:
_:
name: "Require “Allow Edits”"

runs-on: ubuntu-latest

steps:
- uses: ljharb/require-allow-edits@main
8 changes: 8 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
# gitignore
.nyc_output
node_modules

npm-debug.log

# Only apps should have lockfiles
npm-shrinkwrap.json
package-lock.json
yarn.lock

.npmignore
3 changes: 3 additions & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
package-lock=false
allow-same-version=true
message=v%s
16 changes: 0 additions & 16 deletions .travis.yml

This file was deleted.

Loading