Skip to content

Commit 39ed3c4

Browse files
committed
[Tests] avoid publishing "malformed package.json" test to avoid flawed security scanners
Fixes #294. Fixes #274. Fixes #271. Fixes #266. Fixes #265. Fixes #262.
1 parent a9c252e commit 39ed3c4

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,8 @@
7676
"publishConfig": {
7777
"ignore": [
7878
".github/workflows",
79-
"appveyor.yml"
79+
"appveyor.yml",
80+
"test/resolver/malformed_package_json"
8081
]
8182
}
8283
}

test/resolver.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
var path = require('path');
2+
var fs = require('fs');
23
var test = require('tape');
34
var resolve = require('../');
45
var async = require('../async');
@@ -555,14 +556,15 @@ test('absolute paths', function (t) {
555556
});
556557
});
557558

558-
test('malformed package.json', function (t) {
559+
var malformedDir = path.join(__dirname, 'resolver/malformed_package_json');
560+
test('malformed package.json', { skip: !fs.existsSync(malformedDir) }, function (t) {
559561
/* eslint operator-linebreak: ["error", "before"], function-paren-newline: "off" */
560562
t.plan(
561563
(3 * 3) // 3 sets of 3 assertions in the final callback
562564
+ 2 // 1 readPackage call with malformed package.json
563565
);
564566

565-
var basedir = path.join(__dirname, 'resolver/malformed_package_json');
567+
var basedir = malformedDir;
566568
var expected = path.join(basedir, 'index.js');
567569

568570
resolve('./index.js', { basedir: basedir }, function (err, res, pkg) {

test/resolver_sync.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -666,10 +666,11 @@ test('absolute paths', function (t) {
666666
t.end();
667667
});
668668

669-
test('malformed package.json', function (t) {
669+
var malformedDir = path.join(__dirname, 'resolver/malformed_package_json');
670+
test('malformed package.json', { skip: !fs.existsSync(malformedDir) }, function (t) {
670671
t.plan(5 + (requireResolveSupportsPaths ? 1 : 0));
671672

672-
var basedir = path.join(__dirname, 'resolver/malformed_package_json');
673+
var basedir = malformedDir;
673674
var expected = path.join(basedir, 'index.js');
674675

675676
t.equal(

0 commit comments

Comments
 (0)