Skip to content

Added second factor bypass subcategory #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kelbyludwig
Copy link

No description provided.

@kelbyludwig
Copy link
Author

There are a few possible variations of this PR and I'm happy to hear feedback on what the maintainers feel is best:

  • With this change, it may be worthwhile to update the P1 "Authentication Bypass" item to something like "Complete Authentication Bypass".

  • I went with "Second Factor Authentication Bypass", but I think "Second Step Authentication Bypass" or "Partial Authentication Bypass" may apply more generally.

@plr0man
Copy link
Contributor

plr0man commented Sep 15, 2017

The JSON looks fine, but Buildkite can't validate PRs that are done in forked repos. I would definitely recommend opening an issue first in the future, that gives us a chance to provide feedback before filing the PR.
I am not convinced by P2 for bypassing second factor only, after all being able to do so is similar to not having 2FA enabled in terms of security impact, at least in most cases. The difference being the account owner trusting a broken defense-in-depth mechanism.
Looks like theInsufficient Security Configurability->Weak 2FA Implementation subcategory would be the entry of choice here, granted it does not have an assigned priority, but context based seems to be appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants