Skip to content

Adding/applying black to develop branch #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
caleb531 opened this issue Apr 1, 2023 · 2 comments
Closed

Adding/applying black to develop branch #132

caleb531 opened this issue Apr 1, 2023 · 2 comments

Comments

@caleb531
Copy link
Owner

caleb531 commented Apr 1, 2023

@eliotwrobson Another thought for you:

Since I don't know when #129 is going to be finished, I was thinking: it might be nice to backport the black configuration out of your PR into a separate PR to be merged into develop branch. Then I could commit to the feature branch in #129 and run black on the modified files so that they wouldn't conflict with your type hints branch anyway.

In other words, if we can add configuration for black to the develop branch, and apply it to all Python files on develop, and apply it to all files in the open PRs, then we're all on the same page, and we won't have to worry about formatting conflicts ever again. This would also enable us to re-add the CI job sooner.

Thoughts?

@caleb531 caleb531 changed the title Adding black to develop branch Adding/applying black to develop branch Apr 1, 2023
@eliotwrobson
Copy link
Collaborator

@caleb531 I agree with the approach here. The types PR is getting big so splitting off pieces makes it more manageable, and being able to merge the style configuration stuff sooner I think will aid development.

@caleb531
Copy link
Owner Author

caleb531 commented Apr 4, 2023

Closing this issue now that black has been applied to the develop branch for several days now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants