feature: Use the default quality: 0.9 value across all platforms

retyui · retyui · commit c39bc488c5d5 · 2024-02-20T18:39:50.000+01:00
diff --git a/README.md b/README.md
@@ -47,14 +47,14 @@ ImageEditor.cropImage(uri, cropData).then((url) => {
 
 ### `cropData: ImageCropData`
 
-| Property      | Required | Description                                                                                                                                                                                                                                                                                                                                                                                    |
-| ------------- | -------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
-| `offset`      | Yes      | The top-left corner of the cropped image, specified in the original image's coordinate space                                                                                                                                                                                                                                                                                                   |
-| `size`        | Yes      | Size (dimensions) of the cropped image                                                                                                                                                                                                                                                                                                                                                         |
-| `displaySize` | No       | Size to which you want to scale the cropped image                                                                                                                                                                                                                                                                                                                                              |
-| `resizeMode`  | No       | Resizing mode to use when scaling the image (iOS only, Android resize mode is always 'cover', Web - no support) **Default value**: 'contain'                                                                                                                                                                                                                                                   |
-| `quality`     | No       | The quality of the resulting image, expressed as a value from `0.0` to `1.0`. <br/>The value `0.0` represents the maximum compression (or lowest quality) while the value `1.0` represents the least compression (or best quality).<br/>iOS supports only `JPEG` format, while Android/Web supports both `JPEG`, `WEBP` and `PNG` formats.<br/>**Default value**: (iOS: `1`), (Android: `0.9`) |
-| `format`      | No       | The format of the resulting image, possible values are `jpeg`, `png`, `webp`. <br/> **Default value**: based on the provided image; if value determination is not possible, `jpeg` will be used as a fallback. <br/> `webp` isn't supported by iOS.                                                                                                                                             |
+| Property      | Required | Description                                                                                                                                                                                                                                                                                                                                                             |
+| ------------- | -------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
+| `offset`      | Yes      | The top-left corner of the cropped image, specified in the original image's coordinate space                                                                                                                                                                                                                                                                            |
+| `size`        | Yes      | Size (dimensions) of the cropped image                                                                                                                                                                                                                                                                                                                                  |
+| `displaySize` | No       | Size to which you want to scale the cropped image                                                                                                                                                                                                                                                                                                                       |
+| `resizeMode`  | No       | Resizing mode to use when scaling the image (iOS only, Android resize mode is always 'cover', Web - no support) **Default value**: 'contain'                                                                                                                                                                                                                            |
+| `quality`     | No       | The quality of the resulting image, expressed as a value from `0.0` to `1.0`. <br/>The value `0.0` represents the maximum compression (or lowest quality) while the value `1.0` represents the least compression (or best quality).<br/>iOS supports only `JPEG` format, while Android/Web supports both `JPEG`, `WEBP` and `PNG` formats.<br/>**Default value**: `0.9` |
+| `format`      | No       | The format of the resulting image, possible values are `jpeg`, `png`, `webp`. <br/> **Default value**: based on the provided image; if value determination is not possible, `jpeg` will be used as a fallback. <br/> `webp` isn't supported by iOS.                                                                                                                     |
 
 ```ts
 cropData: ImageCropData = {
diff --git a/ios/RNCImageEditor.mm b/ios/RNCImageEditor.mm
@@ -23,6 +23,8 @@
 #import "RCTImageUtils.h"
 #endif
 
+#define DEFAULT_COMPRESSION_QUALITY 0.9
+
 @implementation RNCImageEditor
 
 RCT_EXPORT_MODULE()
@@ -57,7 +59,7 @@ - (void) cropImage:(NSString *)uri
   }
   NSString *displaySize = data.resizeMode();
   NSURLRequest *imageRequest = [NSURLRequest requestWithURL:[NSURL URLWithString: uri]];
-  CGFloat compressionQuality = 1;
+  CGFloat compressionQuality = DEFAULT_COMPRESSION_QUALITY;
   if (data.quality().has_value()) {
     compressionQuality = *data.quality();
   }
@@ -75,7 +77,7 @@ - (void) cropImage:(NSString *)uri
   if(displaySize){
     targetSize = [RCTConvert CGSize:cropData[@"displaySize"]];
   }
-  CGFloat compressionQuality = 1;
+  CGFloat compressionQuality = DEFAULT_COMPRESSION_QUALITY;
   if(cropData[@"quality"]){
       compressionQuality = [RCTConvert CGFloat:cropData[@"quality"]];
   }
diff --git a/src/index.web.ts b/src/index.web.ts
@@ -48,6 +48,8 @@ function fetchImage(imgSrc: string): Promise<HTMLImageElement> {
   });
 }
 
+const QUALITY_DEFAULT = 0.9;
+
 class ImageEditor {
   static cropImage(imgSrc: string, cropData: ImageCropData): Promise<string> {
     /**
@@ -57,7 +59,7 @@ class ImageEditor {
       const canvas = drawImage(image, cropData);
       return canvas.toDataURL(
         `image/${cropData.format ?? 'jpeg'}`,
-        cropData.quality ?? 1
+        cropData.quality ?? QUALITY_DEFAULT
       );
     });
   }

Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,8 @@`
`23`	`23`	`#import "RCTImageUtils.h"`
`24`	`24`	`#endif`
`25`	`25`
	`26`	`+#define DEFAULT_COMPRESSION_QUALITY 0.9`
	`27`	`+`
`26`	`28`	`@implementation RNCImageEditor`
`27`	`29`
`28`	`30`	`RCT_EXPORT_MODULE()`
`@@ -57,7 +59,7 @@ - (void) cropImage:(NSString *)uri`
`57`	`59`	`}`
`58`	`60`	`NSString *displaySize = data.resizeMode();`
`59`	`61`	`NSURLRequest *imageRequest = [NSURLRequest requestWithURL:[NSURL URLWithString: uri]];`
`60`		`- CGFloat compressionQuality = 1;`
	`62`	`+ CGFloat compressionQuality = DEFAULT_COMPRESSION_QUALITY;`
`61`	`63`	`if (data.quality().has_value()) {`
`62`	`64`	`compressionQuality = *data.quality();`
`63`	`65`	`}`
`@@ -75,7 +77,7 @@ - (void) cropImage:(NSString *)uri`
`75`	`77`	`if(displaySize){`
`76`	`78`	`targetSize = [RCTConvert CGSize:cropData[@"displaySize"]];`
`77`	`79`	`}`
`78`		`- CGFloat compressionQuality = 1;`
	`80`	`+ CGFloat compressionQuality = DEFAULT_COMPRESSION_QUALITY;`
`79`	`81`	`if(cropData[@"quality"]){`
`80`	`82`	`compressionQuality = [RCTConvert CGFloat:cropData[@"quality"]];`
`81`	`83`	`}`