Skip to content

Commit 7986cc0

Browse files
authored
fix: floating number problem on android (#649)
* fix: floating number problem on android * fix: change number type from float to double * fix: remove unused imports
1 parent f3fb557 commit 7986cc0

File tree

4 files changed

+10
-9
lines changed

4 files changed

+10
-9
lines changed

package/android/src/main/java/com/reactnativecommunity/slider/ReactSlider.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
import android.view.accessibility.AccessibilityEvent;
1717
import android.view.accessibility.AccessibilityManager;
1818
import androidx.appcompat.widget.AppCompatSeekBar;
19+
1920
import java.net.URL;
2021
import java.util.List;
2122
import java.util.Timer;

package/android/src/main/java/com/reactnativecommunity/slider/ReactSliderManagerImpl.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,11 @@ public static void setValue(ReactSlider view, double value) {
4444
}
4545
}
4646

47-
public static void setMinimumValue(ReactSlider view, float value) {
47+
public static void setMinimumValue(ReactSlider view, double value) {
4848
view.setMinValue(value);
4949
}
5050

51-
public static void setMaximumValue(ReactSlider view, float value) {
51+
public static void setMaximumValue(ReactSlider view, double value) {
5252
view.setMaxValue(value);
5353
}
5454

@@ -60,7 +60,7 @@ public static void setUpperLimit(ReactSlider view, double value) {
6060
view.setUpperLimit(value);
6161
}
6262

63-
public static void setStep(ReactSlider view, float value) {
63+
public static void setStep(ReactSlider view, double value) {
6464
view.setStep(value);
6565
}
6666

package/android/src/newarch/java/com/reactnativecommunity/slider/ReactSliderManager.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,19 +108,19 @@ public void setValue(ReactSlider view, float value) {
108108

109109
@Override
110110
@ReactProp(name = "minimumValue", defaultFloat = 0f)
111-
public void setMinimumValue(ReactSlider view, float value) {
111+
public void setMinimumValue(ReactSlider view, double value) {
112112
ReactSliderManagerImpl.setMinimumValue(view, value);
113113
}
114114

115115
@Override
116116
@ReactProp(name = "maximumValue", defaultFloat = 0f)
117-
public void setMaximumValue(ReactSlider view, float value) {
117+
public void setMaximumValue(ReactSlider view, double value) {
118118
ReactSliderManagerImpl.setMaximumValue(view, value);
119119
}
120120

121121
@Override
122122
@ReactProp(name = "step", defaultFloat = 0f)
123-
public void setStep(ReactSlider view, float value) {
123+
public void setStep(ReactSlider view, double value) {
124124
ReactSliderManagerImpl.setStep(view, value);
125125
}
126126

package/android/src/oldarch/java/com/reactnativecommunity/slider/ReactSliderManager.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -126,17 +126,17 @@ public void setValue(ReactSlider view, float value) {
126126
}
127127

128128
@ReactProp(name = "minimumValue", defaultFloat = 0f)
129-
public void setMinimumValue(ReactSlider view, float value) {
129+
public void setMinimumValue(ReactSlider view, double value) {
130130
ReactSliderManagerImpl.setMinimumValue(view, value);
131131
}
132132

133133
@ReactProp(name = "maximumValue", defaultFloat = 1f)
134-
public void setMaximumValue(ReactSlider view, float value) {
134+
public void setMaximumValue(ReactSlider view, double value) {
135135
ReactSliderManagerImpl.setMaximumValue(view, value);
136136
}
137137

138138
@ReactProp(name = "lowerLimit")
139-
public void setLowerLimit(ReactSlider view, float value) {
139+
public void setLowerLimit(ReactSlider view, double value) {
140140
ReactSliderManagerImpl.setLowerLimit(view, value);
141141
}
142142

0 commit comments

Comments
 (0)