Skip to content

Height on style object not working #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
peter571 opened this issue Jan 15, 2025 · 2 comments · Fixed by #702
Closed

Height on style object not working #680

peter571 opened this issue Jan 15, 2025 · 2 comments · Fixed by #702
Labels
bug report Something isn't working

Comments

@peter571
Copy link

Height of the Slider not adjusting when modified on the style object

@github-project-automation github-project-automation bot moved this to To be analyzed in Slider-Board Feb 21, 2025
@BartoszKlonowski BartoszKlonowski added the bug report Something isn't working label Feb 21, 2025
@kacperzolkiewski
Copy link

Hi @peter571,

I was investigating the code and noticed that in Slider.tsx, the styles for the Slider View are defined in a way that might cause issues.

Currently, the styles are applied like this:
1️⃣ props.style is applied first.
2️⃣ Then, defaultStyles are applied, which might overwrite user-provided styles.

This could lead to unintended styling behavior.
🔗 Here’s the relevant line: #236

Would it be okay if I submitted a fix for this @BartoszKlonowski? I can adjust the order so that props.style correctly overrides the defaults instead of the other way around.

Let me know your thoughts! Thanks.

@BartoszKlonowski
Copy link
Member

Thanks for reporting the issue, @peter571 and thank you for investigating, @kacperzolkiewski 💪
PRs are always welcome, there's no need to ask for permissions to create one. If your proposal is still valid then please create a PR with the proposed solution you describe and I'll check.
As for the delay with my response - don't hesitate to reach out to me on our Slider channel on Discord in case of having some thoughts, ideas or questions, or in case of me missing a comment on a specific issue.

@BartoszKlonowski BartoszKlonowski moved this from To be analyzed to Backlog in Slider-Board Apr 18, 2025
@BartoszKlonowski BartoszKlonowski moved this from Backlog to In Progress in Slider-Board May 16, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Slider-Board May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants