Skip to content

Commit 1f8ac87

Browse files
committed
bug(fcsfile): fix recursion when file has no spill string
1 parent 47dcff1 commit 1f8ac87

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

cellengine/resources/fcs_file.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@ class FcsFile(DataClassMixin):
3535
sample_name: Optional[str] = field(default=ReadOnly(optional=True)) # type: ignore
3636
size: int = field(default=ReadOnly()) # type: ignore
3737
_spill_string: Optional[str] = field(
38-
metadata=config(field_name="spillString"), default=None
38+
metadata=config(field_name="spillString"),
39+
default=None,
3940
)
4041

4142
def __repr__(self):
@@ -226,9 +227,12 @@ def spill_string(self):
226227
if self._spill_string:
227228
return self._spill_string
228229
else:
229-
ss = ce.APIClient().get_fcs_file(self.experiment_id, self._id).spill_string
230-
self._spill_string = ss
231-
return ss
230+
ss = ce.APIClient().get_fcs_file(self.experiment_id, self._id, as_dict=True)
231+
if ss["spillString"]:
232+
self._spill_string = ss["spillString"]
233+
else:
234+
self._spill_string = ""
235+
return self._spill_string
232236

233237
def get_events(
234238
self, inplace: bool = False, destination=None, **kwargs

0 commit comments

Comments
 (0)