Plugin: ExerciseFocused: Round number of random results - refs BT#21074

AngelFQC · AngelFQC · commit 3c13b4f83391 · 2023-12-06T17:10:24.000-05:00
diff --git a/plugin/exercisefocused/src/Traits/ReportingFilterTrait.php b/plugin/exercisefocused/src/Traits/ReportingFilterTrait.php
@@ -378,8 +378,9 @@ private function pickRandomAttempts(array $attemptIdList): array
         }
 
         $percentage = count($attemptIdList) * ($settingPercentage / 100);
+        $round = round($percentage) ?: 1;
 
-        $random = (array) array_rand($attemptIdList, ceil($percentage));
+        $random = (array) array_rand($attemptIdList, $round);
 
         $selection = [];
 

Original file line number	Diff line number	Diff line change
`@@ -378,8 +378,9 @@ private function pickRandomAttempts(array $attemptIdList): array`
`378`	`378`	`}`
`379`	`379`
`380`	`380`	`$percentage = count($attemptIdList) * ($settingPercentage / 100);`
	`381`	`+ $round = round($percentage) ?: 1;`
`381`	`382`
`382`		`- $random = (array) array_rand($attemptIdList, ceil($percentage));`
	`383`	`+ $random = (array) array_rand($attemptIdList, $round);`
`383`	`384`
`384`	`385`	`$selection = [];`
`385`	`386`