Skip to content

deal with disabled bcc_self after successful backup-transfer #4183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #4180
r10s opened this issue Mar 20, 2023 · 2 comments
Closed
Tracked by #4180

deal with disabled bcc_self after successful backup-transfer #4183

r10s opened this issue Mar 20, 2023 · 2 comments

Comments

@r10s
Copy link
Contributor

r10s commented Mar 20, 2023

if setting up another device succeeded, but bcc_self is disabled, this will cause problems in all situations the user wants to use two devices afterwards.

while since 2 years, the default is "enabled", there are still older installations - and for some providers, we use a different default (eg. nauta has bcc_self disabled by default) - so we can expect this to be an issue on quite some installations.

options to deal with that would be

(1) enable bcc_self after a successful transfer

(2) add a warning if bcc_self is disabled after a successful transfer (we should make sure, the warning is not notified or so during transfer, for the warning itself, we can just reuse maybe_add_bcc_self())

at #825 we decided not to change bcc_self for the autocrypt setup message, because of leaving user decisions alone, and decided for (2) - not sure if that is still a valid argument for backup-transfer, which seems to be much more related to actually using a seconds device.

@iequidoo
Copy link
Collaborator

iequidoo commented Mar 22, 2023

(1) enable bcc_self after a successful transfer

Better before. From the viewpoint of the sending device it can fail, but actually may succeed because of the failure of final status reporting :) And we can show also a message to a user "bcc_self was enabled because..."
EDIT: And if enabled before the transfer, no fixup is needed on the new device.

@r10s
Copy link
Contributor Author

r10s commented Nov 11, 2024

closing stale issue.

also, the issue got much smaller, as for chatmail, we do not allow to alter bcc self at all - and for the other cases, it is "advanced", and these "power users" should know what they're doing :)
we also did few complains here, maybe the issue was never that big :)

@r10s r10s closed this as not planned Won't fix, can't repro, duplicate, stale Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants