Skip to content

BackupProvider JSON-RPC: make getting QR code easier #4191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #4180
flub opened this issue Mar 21, 2023 · 0 comments · Fixed by #4198
Closed
Tracked by #4180

BackupProvider JSON-RPC: make getting QR code easier #4191

flub opened this issue Mar 21, 2023 · 0 comments · Fixed by #4198
Assignees

Comments

@flub
Copy link
Contributor

flub commented Mar 21, 2023

Currently a user of the JSON-RPC API has to guess when they can call the function to retrieve the QR code. They can hack around this by waiting for a specific IMEX progress event but that's not nice either.

The proposal would be make the get_backup_qr() method blocking if there is currently a call to provide_backup() and once the QR code is available it would return. If get_backup_qr() is called without a current provide_backup() call it will error immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant