-
Notifications
You must be signed in to change notification settings - Fork 987
Feature/fix datestamps #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/fix datestamps #113
Conversation
Hi Reinhard, Thank you for this pull request! Am I correct in assuming, that you will Kind regards, |
Yes, that'd be great. Thanks, |
Hi Reinhard, I have assigned this pull request to 1.34.1, which I plan to release during December. Best regards, |
<configuration> | ||
<source>1.8</source> | ||
<target>1.8</target> | ||
</configuration> | ||
</plugin> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a property "maven.compiler.source" and "...target" in the properties section. Could you please either delete those properties or remove the entries here and update the properties in the properties section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the properties. I don't see much use in these properties in this case. I wasn't even aware that it can be configured like this.
I obviously haven't gotten around to merge this until end of December. I have moved the target date of the release to end of January. Maybe, I'll be able to merge it earlier. |
...and thanks for the updates to the pull request! |
Fixes #112.