Command line graph generation random issue #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command line graph generation might fail due to a concurrency issue. The SimpleChartRenderer is called by 'main' thread, it creates a ModelChartImpl, initialize it and validates. And calls setScaleFactor that calls repaint (suspicious). For some reason when paint is called on the BufferedImage I get an half-drawn graph. To be sure in any case, I rather do any swing call within the EventDispatchThread
|
Thanks for your pull request, I have merged it! The latest SNAPSHOT-1.35 contains your commit. |
|
You're welcome |
chewiebug
added a commit
that referenced
this pull request
May 3, 2015
chewiebug
added a commit
that referenced
this pull request
May 13, 2015
* develop: reduce number of WARNING messages when parsing introduction of a detailed G1 message fails (#128) add Àngel Ollé Blázquez to list of contributors fix merge problem between #129 and #130 export graph to PNG fature using the GCViewer GUI Command line graph generation random issue parallel scavenge collector: handle combination of -XX:+PrintAdaptiveSizePolicy, -XX:+PrintTenuringDistribution, -XX:+PrintApplicationStoppedTime (#128) fix negative pause for VM_OPERATION event near parser problem (#128) Conflicts: src/main/java/com/tagtraum/perf/gcviewer/exp/impl/DataWriterFactory.java src/main/java/com/tagtraum/perf/gcviewer/view/SimpleChartRenderer.java src/test/java/com/tagtraum/perf/gcviewer/imp/TestDataReaderSun1_7_0G1.java src/test/java/com/tagtraum/perf/gcviewer/imp/TestDataReaderSun1_8_0G1.java
chewiebug
added a commit
that referenced
this pull request
May 13, 2015
* develop: reduce number of WARNING messages when parsing introduction of a detailed G1 message fails (#128) add Àngel Ollé Blázquez to list of contributors fix merge problem between #129 and #130 export graph to PNG fature using the GCViewer GUI Command line graph generation random issue parallel scavenge collector: handle combination of -XX:+PrintAdaptiveSizePolicy, -XX:+PrintTenuringDistribution, -XX:+PrintApplicationStoppedTime (#128) fix negative pause for VM_OPERATION event near parser problem (#128)
areese
pushed a commit
to areese/GCViewer
that referenced
this pull request
Oct 5, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command line graph generation might fail due to a concurrency issue.
The SimpleChartRenderer is called by 'main' thread, it creates a
ModelChartImpl, initialize it and validates. And calls setScaleFactor
that calls repaint (suspicious). For some reason when paint is called on
the BufferedImage I get an half-drawn graph.
To be sure in any case, I rather do any swing call within the
EventDispatchThread