Skip to content

Commit 175cf46

Browse files
committed
doc: Start converting readme's TODOs into GitHub issues
Filed issues zulip#161, zulip#162, zulip#163, zulip#164, zulip#165, zulip#166, zulip#167, zulip#168, zulip#169, zulip#170, zulip#171, zulip#172, zulip#173, zulip#174, zulip#175.
1 parent 72f766c commit 175cf46

File tree

3 files changed

+8
-36
lines changed

3 files changed

+8
-36
lines changed

README.md

Lines changed: 4 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -126,34 +126,17 @@ To update the version bounds:
126126

127127
## TODO
128128

129-
### Server API
129+
In general, see [the issue tracker][].
130+
Some items written below in an early phase of the project
131+
may not yet have been converted into issues.
130132

131-
Much more to write.
132-
133-
134-
### State and storage
135-
136-
Much more to design and write.
133+
[the issue tracker]: https://github.com/zulip/zulip-flutter/issues
137134

138135

139136
### Message content
140137

141-
If necessary we could put the message list in a webview, like we do
142-
in React Native. But the current plan is to handle it with Flutter
143-
widgets.
144-
145138
- Lots of specific types of elements; see TODO comments
146139

147-
- Specific types of elements that may inform architecture:
148-
- List item indicators according to nesting level
149-
- Layout interactions like `p+ul`
150-
- Lightbox for image attachments
151-
- TeX
152-
153-
- Font
154-
155-
- Polls
156-
157140
- Survey lots of messages to find unhandled types of elements
158141
- Survey all public messages on chat.zulip.org
159142
- Survey all public messages on [listed open communities][]
@@ -163,17 +146,6 @@ widgets.
163146

164147
### Message list, other than content
165148

166-
- Show more/better message metadata:
167-
- Starred
168-
- Edited/moved
169-
170-
- Handle layout/UI interactions between messages:
171-
- Sender names/avatars
172-
- Recipient headers
173-
- Date separators
174-
175-
- UI to interact with messages
176-
177149
- Scroll position at first unread, or via link (vs. latest)
178150

179151
- Dark theme (and in content too)

lib/model/message_list.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,8 @@ class MessageListView extends ChangeNotifier {
9898

9999
static Iterable<ZulipContent> _contentsOfMessages(Iterable<Message> messages) {
100100
// This will get more complicated to handle the ways that messages interact
101-
// with the display of neighboring messages: sender headings,
102-
// recipient headings, and date separators.
101+
// with the display of neighboring messages: sender headings #175,
102+
// recipient headings #174, and date separators #173.
103103
// TODO factor [messages] and [contents] into own class to encapsulate that
104104
return messages.map((message) => parseContent(message.content));
105105
}

lib/widgets/content.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,12 +145,12 @@ class ListNodeWidget extends StatelessWidget {
145145

146146
@override
147147
Widget build(BuildContext context) {
148-
// TODO p+ul and p+ol interactions
148+
// TODO(#162): p+ul and p+ol interactions
149149
final items = List.generate(node.items.length, (index) {
150150
final item = node.items[index];
151151
String marker;
152152
switch (node.style) {
153-
// TODO different unordered marker styles at different levels of nesting
153+
// TODO(#161): different unordered marker styles at different levels of nesting
154154
// see:
155155
// https://html.spec.whatwg.org/multipage/rendering.html#lists
156156
// https://www.w3.org/TR/css-counter-styles-3/#simple-symbolic

0 commit comments

Comments
 (0)