fix(clerk-js): Fix act output in tests [SDK-1054] (#2289)

* fix(clerk-js): Fix unhandled act errors [SDK-1054]

* chore(*): Add changeset

* chore(clerk-js): Add missing awaits

* chore(clerk-js): Minor updates

Author: tmilewski

.changeset/cold-coins-listen.md

@@ -0,0 +1,5 @@
+---
+'@clerk/clerk-js': patch
+---
+
+Fixes errant `act` output from unit tests

packages/clerk-js/src/core/clerk.test.ts

@@ -519,7 +519,7 @@ describe('Clerk singleton', () => {
     let logSpy;
 
     beforeEach(() => {
-      logSpy = jest.spyOn(console, 'log');
+      logSpy = jest.spyOn(console, 'log').mockReturnValue(void 0);
       sut = new Clerk(productionPublishableKey);
     });
 

packages/clerk-js/src/ui.retheme/components/OrganizationProfile/__tests__/InviteMembersPage.test.tsx

@@ -1,7 +1,6 @@
 import type { MembershipRole, OrganizationInvitationResource } from '@clerk/types';
 import { describe } from '@jest/globals';
 import { waitFor } from '@testing-library/dom';
-import { act } from '@testing-library/react';
 import React from 'react';
 
 import { ClerkAPIResponseError } from '../../../../core/resources';
@@ -15,12 +14,16 @@ describe('InviteMembersPage', () => {
   it('renders the component', async () => {
     const { wrapper, fixtures } = await createFixtures(f => {
       f.withOrganizations();
-      f.withUser({ email_addresses: ['[email protected]'], organization_memberships: [{ name: 'Org1', role: 'admin' }] });
+      f.withUser({
+        email_addresses: ['[email protected]'],
+        organization_memberships: [{ name: 'Org1', role: 'admin' }],
+      });
     });
 
     fixtures.clerk.organization?.getRoles.mockRejectedValue(null);
-    const { getByText } = await act(() => render(<InviteMembersPage />, { wrapper }));
-    expect(getByText('Invite new members to this organization')).toBeDefined();
+
+    const { findByText } = render(<InviteMembersPage />, { wrapper });
+    await waitFor(async () => expect(await findByText('Invite new members to this organization')).toBeInTheDocument());
   });
 
   describe('Submitting', () => {
@@ -42,6 +45,7 @@ describe('InviteMembersPage', () => {
 
       await userEvent.click(getByRole('button', { name: /select an option/i }));
       await userEvent.click(getByText(/^member$/i));
+
       expect(getByRole('button', { name: 'Send invitations' })).not.toBeDisabled();
     });
 
@@ -61,9 +65,12 @@ describe('InviteMembersPage', () => {
       await userEvent.click(getByRole('button', { name: 'Select an option' }));
       await userEvent.click(getByText('Member'));
       await userEvent.click(getByRole('button', { name: 'Send invitations' }));
-      expect(fixtures.clerk.organization?.inviteMembers).toHaveBeenCalledWith({
-        emailAddresses: ['[email protected]'],
-        role: 'basic_member' as MembershipRole,
+
+      await waitFor(() => {
+        expect(fixtures.clerk.organization?.inviteMembers).toHaveBeenCalledWith({
+          emailAddresses: ['[email protected]'],
+          role: 'basic_member' as MembershipRole,
+        });
       });
     });
 
@@ -98,9 +105,12 @@ describe('InviteMembersPage', () => {
       await userEvent.click(getByRole('button', { name: 'Select an option' }));
       await userEvent.click(getByText('Teacher'));
       await userEvent.click(getByRole('button', { name: 'Send invitations' }));
-      expect(fixtures.clerk.organization?.inviteMembers).toHaveBeenCalledWith({
-        emailAddresses: ['[email protected]'],
-        role: 'org:teacher' as MembershipRole,
+
+      await waitFor(() => {
+        expect(fixtures.clerk.organization?.inviteMembers).toHaveBeenCalledWith({
+          emailAddresses: ['[email protected]'],
+          role: 'org:teacher' as MembershipRole,
+        });
       });
     });
 
@@ -123,9 +133,12 @@ describe('InviteMembersPage', () => {
       await userEvent.click(getByRole('button', { name: 'Select an option' }));
       await userEvent.click(getByText('Member'));
       await userEvent.click(getByRole('button', { name: 'Send invitations' }));
-      expect(fixtures.clerk.organization?.inviteMembers).toHaveBeenCalledWith({
-        emailAddresses: ['[email protected]', '[email protected]', '[email protected]', '[email protected]'],
-        role: 'basic_member' as MembershipRole,
+
+      await waitFor(() => {
+        expect(fixtures.clerk.organization?.inviteMembers).toHaveBeenCalledWith({
+          emailAddresses: ['[email protected]', '[email protected]', '[email protected]', '[email protected]'],
+          role: 'basic_member' as MembershipRole,
+        });
       });
     });
 
@@ -145,9 +158,11 @@ describe('InviteMembersPage', () => {
       await userEvent.click(getByRole('button', { name: 'Select an option' }));
       await userEvent.click(getByText('Admin'));
       await userEvent.click(getByRole('button', { name: 'Send invitations' }));
-      expect(fixtures.clerk.organization?.inviteMembers).toHaveBeenCalledWith({
-        emailAddresses: ['[email protected]'],
-        role: 'admin' as MembershipRole,
+      await waitFor(() => {
+        expect(fixtures.clerk.organization?.inviteMembers).toHaveBeenCalledWith({
+          emailAddresses: ['[email protected]'],
+          role: 'admin' as MembershipRole,
+        });
       });
     });