Compiling 2021.8.3 using Go 1.17 fails

[jauderho]

This was working with no errors for 2021.8.2.

The error message is https://github.com/jauderho/dockerfiles/runs/3419574175?check_suite_focus=true#step:8:2063

Seems to be a known issue as caddyserver is reporting similar issues. See caddyserver/caddy#4118

For now, I've reverted to building with Go 1.16.

[francislavoie]

This only requires updating quic-go to the latest version.

cloudflared/go.mod

Line 32 in 4ff215e

github.com/lucas-clemente/quic-go v0.20.0

It's already been fixed in Caddy. caddyserver/caddy#4297

[jauderho]

Looks like @sudarshan-reddy downgraded quic-go to 0.20.0 a few days ago in 1082ac1

quic-go did fix the panic in 0.21.2 which is newer than what the commit downgraded from (0.21.1)

[nmldiegues]

Looks like @sudarshan-reddy downgraded quic-go to 0.20.0 a few days ago in 1082ac1

Yes, we've had to downgrade to avoid pulling golang/go#43989 back in.
We'll check how we can reconcile both problems.

In the meantime, out of curiosity, what's driving you to compile the repo on every release?

[jauderho]

@nmldiegues Mostly as a way of learning to build minimal multi-platform images for things that I use as well as GitHub Actions. After a bunch of trials, I think I figured out a fairly clean way to build images (in particular, go based apps) to the point where I can containerize a Go binary in about 15-20 mins.

Feel free to take a look at https://github.com/jauderho/dockerfiles or #422 (comment) (for details around specifically around how I build cloudflared)

[sudarshan-reddy]

I'm actively working on this upgrade and syncing it with our build system. I'll keep you guys posted.

[sudarshan-reddy]

This is now fixed.

sudarsanreddy@C02DN0YPMD6R cloudflared % go version

go version go1.17 darwin/amd64
sudarsanreddy@C02DN0YPMD6R cloudflared % make cloudflared

GOOS=darwin GOARCH=amd64 go build -v -mod=vendor  -ldflags='-X "main.Version=2021.8.3-6-g414cb12f-dev" -X "main.BuildTime=2021-08-27-2006 UTC"' github.com/cloudflare/cloudflared/cmd/cloudflared