Skip to content

Commit 746b44e

Browse files
committed
fix golangci-lint --fix and Remove --path-prefix flag
Already [opened Issue](golangci/golangci-lint#2293)
1 parent 26776a1 commit 746b44e

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

Makefile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,8 @@ lint-actions:
253253

254254
$(addprefix lint_,$(go_modules)): lint_%:
255255
@echo " - linting: $(patsubst lint_%,%,$@)"
256-
@pushd src/$(patsubst lint_%,%,$@) >/dev/null && golangci-lint run --path-prefix=src/$(patsubst lint_%,%,$@) --config ${lint_config} ${OPTS}
256+
@echo " receiving OPTS ${OPTS}"
257+
@pushd src/$(patsubst lint_%,%,$@) >/dev/null && golangci-lint run --config ${lint_config} ${OPTS}
257258

258259
.PHONY: spec-test
259260
spec-test:

src/acceptance/run_performance/run_performance_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ var _ = Describe("Scale in and out (eg: 30%) percentage of apps", func() {
5656

5757
samplingConfig = gmeasure.SamplingConfig{
5858
N: actualAppsToScaleCount,
59-
NumParallel: 100,
59+
NumParallel: 100, // number of sample to execute at a time
6060
Duration: 300 * time.Minute,
6161
}
6262
experiment = gmeasure.NewExperiment("Scaling Benchmark")

src/acceptance/setup_performance/setup_performance_suite_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,15 @@ import (
44
"acceptance/config"
55
. "acceptance/helpers"
66
"fmt"
7-
"github.com/KevinJCross/cf-test-helpers/v2/cf"
8-
"github.com/onsi/gomega/gexec"
97
"os"
108
"strconv"
119
"sync"
1210
"testing"
1311
"time"
1412

13+
"github.com/KevinJCross/cf-test-helpers/v2/cf"
14+
"github.com/onsi/gomega/gexec"
15+
1516
"github.com/KevinJCross/cf-test-helpers/v2/workflowhelpers"
1617

1718
. "github.com/onsi/ginkgo/v2"
@@ -88,7 +89,6 @@ func cleanup() {
8889
if len(spaceNames) == 0 {
8990
return
9091
}
91-
//TODO - Do it with multiple go processes
9292
waitGroup := sync.WaitGroup{}
9393
waitGroup.Add(2)
9494

0 commit comments

Comments
 (0)