Skip to content

Could you add Node 5.1.0? #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
martinotten opened this issue Nov 23, 2015 · 6 comments
Closed

Could you add Node 5.1.0? #37

martinotten opened this issue Nov 23, 2015 · 6 comments

Comments

@martinotten
Copy link

As of now the release of Node 5.1.0 is stable, even though it has no LTS. Could you please add it to the manifest?

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/108744164.

@flavorjones
Copy link
Contributor

Hi, we've received little-to-no feedback on support for node 4.2.x, and so I'm hesitant to add more versions based on the statically-linked-openssl-1.0.2 strategy described in #32.

Have you tried Node 4.2?

@martinotten
Copy link
Author

Sure, and it works. But we would prefer to develop for the most recent stable version and have all features available.

@cloudlena
Copy link

I couldn't agree more with @Mobbit. Also, many of our users hadn't specified the node engine version in their package.json which lead to them getting errors upon pushing which they didn't understand because the buildpack was trying to download the latest stable version (5.1.0) but couldn't find it...

@voelzmo
Copy link

voelzmo commented Nov 24, 2015

I guess the version resolver shouldn't come up with a version which is not supported by the buildpack? As long as engine is not a mandatory field, it should probably just work(tm) to push an app without that property.

@Dannyzen
Copy link
Contributor

Dannyzen commented Dec 4, 2015

Hi, we're planning supporting 5.1.1 in the next release which should roll out today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants