Skip to content

Commit 61bca91

Browse files
committed
Fix clippy
1 parent 882aa4d commit 61bca91

File tree

1 file changed

+11
-24
lines changed
  • parquet-variant-compute/src/variant_get

1 file changed

+11
-24
lines changed

parquet-variant-compute/src/variant_get/mod.rs

Lines changed: 11 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1159,17 +1159,12 @@ mod test {
11591159
fn create_depth_1_shredded_test_data_working() -> ArrayRef {
11601160
// Create metadata following the working pattern from shredded_object_with_x_field_variant_array
11611161
let (metadata, _) = {
1162-
// Create nested structure: {"a": {"x": 55}, "b": 42}
1163-
let a_variant = {
1164-
let mut a_builder = parquet_variant::VariantBuilder::new();
1165-
let mut a_obj = a_builder.new_object();
1166-
a_obj.insert("x", Variant::Int32(55)); // "a.x" field (shredded when possible)
1167-
a_obj.finish().unwrap()
1168-
};
1169-
11701162
let mut builder = parquet_variant::VariantBuilder::new();
1163+
// Create nested structure: {"a": {"x": 55}, "b": 42}
11711164
let mut obj = builder.new_object();
1172-
obj.insert("a", a_variant);
1165+
let mut a_obj = obj.new_object("x");
1166+
a_obj.insert("x", Variant::Int32(55)); // "a.x" field (shredded when possible)
1167+
a_obj.finish().unwrap();
11731168
obj.insert("b", Variant::Int32(42));
11741169
obj.finish().unwrap();
11751170
builder.finish()
@@ -1273,23 +1268,15 @@ mod test {
12731268
// Create metadata following the working pattern
12741269
let (metadata, _) = {
12751270
// Create deeply nested structure: {"a": {"b": {"x": 100}}}
1276-
let b_variant = {
1277-
let mut b_builder = parquet_variant::VariantBuilder::new();
1278-
let mut b_obj = b_builder.new_object();
1279-
b_obj.insert("x", Variant::Int32(100));
1280-
b_obj.finish().unwrap()
1281-
};
1282-
1283-
let a_variant = {
1284-
let mut a_builder = parquet_variant::VariantBuilder::new();
1285-
let mut a_obj = a_builder.new_object();
1286-
a_obj.insert("b", b_variant);
1287-
a_obj.finish().unwrap()
1288-
};
1289-
1271+
12901272
let mut builder = parquet_variant::VariantBuilder::new();
1273+
// Create deeply nested structure: {"a": {"b": {"x": 100}}}
12911274
let mut obj = builder.new_object();
1292-
obj.insert("a", a_variant); // "a" field containing b
1275+
let mut a_obj = obj.new_object("a");
1276+
let mut b_obj = a_obj.new_object("b");
1277+
b_obj.insert("x", Variant::Int32(100)); // "a.b.x" field (shredded when possible)
1278+
b_obj.finish().unwrap();
1279+
a_obj.finish().unwrap();
12931280
obj.finish().unwrap();
12941281
builder.finish()
12951282
};

0 commit comments

Comments
 (0)