Skip to content

Add basic integration tests for all endpoints #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
33 of 36 tasks
rzats opened this issue Jan 18, 2023 · 2 comments
Closed
33 of 36 tasks

Add basic integration tests for all endpoints #1068

rzats opened this issue Jan 18, 2023 · 2 comments
Assignees
Labels
help wanted tests integration & unit testing, bug triage and prevention

Comments

@rzats
Copy link
Contributor

rzats commented Jan 18, 2023

This PR #1062 had some endpoints with missing imports, but passed integration testing. We should make sure all endpoints are covered by basic integration tests ("doesn't throw an error") to prevent this from happening.

Missing imports were fixed in #1067.

Starter list of endpoints:

  • afhsb (table doesn't exist; Disable/remove afhsb endpoint #1141 to remove)
  • cdc
  • covid_hosp_facility
  • covid_hosp_facility_lookup
  • covid_hosp_state_timeseries
  • covidcast
  • covidcast/meta
  • TODO: list additional covidcast/ endpoints from covidcast.py
  • covidcast_meta (different from covidcast/meta)
  • covidcast_nowcast
  • delphi
  • dengue_nowcast
  • dengue_sensors
  • ecdc_ili
  • flusurv
  • fluview
  • fluview_clinical
  • fluview_meta
  • gft
  • ght
  • ilinet (replaced with fluview)
  • kcdc_ili
  • meta
  • meta_afhsb (table doesn't exist; Disable/remove afhsb endpoint #1141 to remove)
  • meta_norostat
  • nidss_dengue
  • nidss_flu
  • norostat
  • nowcast
  • paho_dengue
  • quidel
  • sensors
  • signal_dashboard_coverage
  • signal_dashboard_status
  • twitter
  • wiki

For each we need to:

  1. see if it has coverage in integration tests
  2. if so, check it off
  3. if not, add a test, then check it off
@melange396 melange396 added the tests integration & unit testing, bug triage and prevention label Jan 23, 2023
@melange396
Copy link
Collaborator

possibly helpful: Dmitry "dug through the old endpoints and got one non-trivial response query for almost all of them" (slack message)

@dmytrotsko dmytrotsko self-assigned this Jul 13, 2023
@dmytrotsko dmytrotsko linked a pull request Jul 20, 2023 that will close this issue
3 tasks
@melange396
Copy link
Collaborator

done in #1241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted tests integration & unit testing, bug triage and prevention
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants