Skip to content

API request geo-validation excludes some valid regions #1641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
melange396 opened this issue Apr 18, 2025 · 0 comments
Open

API request geo-validation excludes some valid regions #1641

melange396 opened this issue Apr 18, 2025 · 0 comments
Labels
api change affect the API and its responses bug user experience things that affect users of our software or services

Comments

@melange396
Copy link
Collaborator

Validation of geographic values used in requests went into the API server code with #1095 . It uses our GeoMapper utility to determine if a geo value is valid but, unfortunately, this has some problems. geo=county:02261 exists in our data, but is not allowed by the request validator; the FIPS code previously existed but was split into two new regions in 2020 definitions. The GeoMapper uses 2020 definitions by default, but we also have 2019 definitions available. Thus, data for that region cannot be retrieved specifically (though it will be delivered along with other geos if using a wildcard ("geo=county:*") in the request).

Possibilities to address it include:

  • using merged 2019 + 2020 definitions in the validator
  • allowing any geo_values that are present in the database

Related:

@melange396 melange396 added api change affect the API and its responses bug user experience things that affect users of our software or services labels Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api change affect the API and its responses bug user experience things that affect users of our software or services
Projects
None yet
Development

No branches or pull requests

1 participant