Skip to content

configure CI to use a secret API key #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dshemetov opened this issue Apr 17, 2023 · 1 comment · Fixed by #123
Closed

configure CI to use a secret API key #87

dshemetov opened this issue Apr 17, 2023 · 1 comment · Fixed by #123
Labels
later P1 medium priority

Comments

@dshemetov
Copy link
Contributor

dshemetov commented Apr 17, 2023 •
edited
Loading

todo: configure CI to use a key. Else I expect the examples to generate warning messages. Think we can use GitHub Secrets. I've played around with those here if you haven't already used them as part of production work.

Originally posted by @brookslogan in #79 (comment)
@dshemetov dshemetov changed the title todo: configure CI to use a key. Else I expect the examples to generate warning messages. Think we can use GitHub Secrets. I've played around with those [here](https://github.com/brookslogan/testing-bots-001/blob/main/.github/workflows/label-questions-stale.yml) if you haven't already used them as part of production work. configure CI to use a secret API key Apr 17, 2023
@dshemetov dshemetov added P1 medium priority later labels Apr 18, 2023
@dshemetov
Copy link
Contributor Author

Currently our CI is building vignettes which make many calls to the API and this doesn't hit the API limit if not run too many times.

In the long run we should add a key as a secret.

@brookslogan brookslogan mentioned this issue Jun 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
later P1 medium priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: set DELPHI_EPIDATA_KEY, from a GitHub Secret cmu-delphi/epidatr
1 participant
@dshemetov