Skip to content

Bug in names<-.epi_df #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brookslogan opened this issue Apr 24, 2023 · 2 comments
Closed

Bug in names<-.epi_df #305

brookslogan opened this issue Apr 24, 2023 · 2 comments
Assignees
Labels
bug Something isn't working P1 medium priority

Comments

@brookslogan
Copy link
Contributor

The attributes of x are potentially changed, but this has no impact on the return value. x here should probably be result, or result, result should be result, x.

[...]
  result = NextMethod()
  attributes(x)$metadata$other_keys <- value[match(old_other_keys, old_names)]
  dplyr::dplyr_reconstruct(result, result)

This would break the removed-other_keys-dropping.

@brookslogan brookslogan added bug Something isn't working P1 medium priority labels Apr 24, 2023
@brookslogan
Copy link
Contributor Author

Needs reprex @brookslogan

@brookslogan brookslogan self-assigned this Oct 25, 2023
@dsweber2 dsweber2 added this to the Epiprocess Issue Triage milestone Oct 25, 2023
@brookslogan
Copy link
Contributor Author

Already fixed by b9bac78 in #390.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1 medium priority
Projects
None yet
Development

No branches or pull requests

2 participants