Skip to content

Fix temporary key setting in filter.epi_archive that has to be reset #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

brookslogan
Copy link
Contributor

Checklist

Please:

  • Make sure this PR is against "dev", not "main" (unless this is a release
    PR).
  • Request a review from one of the current main reviewers:
    brookslogan, nmdefries.
  • Makes sure to bump the version number in DESCRIPTION. Always increment
    the patch version number (the third number), unless you are making a
    release PR from dev to main, in which case increment the minor version
    number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    1.7.2, then write your changes under the 1.8 heading).
  • Styling and documentation checks. Make a PR comment with:
    • /document to check the package documentation and fix any issues.
    • /style to check the style and fix any issues.
    • /preview-docs to preview the docs.
    • See Actions GitHub tab to track progress of these commands.
  • See DEVELOPMENT.md for more information on the development
    process.

Change explanations for reviewer

filter.epi_archive sets a data.table's key before feeding it into new_epi_archive, thinking that / planning for new_epi_archive to require the key to already be set properly. But it did it improperly. Thankfully, new_epi_archive actually just does a second round of sorting if required. There are some warnings in some versions of data.table in some cases from the bogus intermediate key.

The archive key ordering is still a bit weird... I thought I already completed most of the geo-time-other[-version] --> geo-other-time[-version] changes, but apparently not. Not adjusting this now because example data sets need checked.

Don't think this is worth a version bump or changelog entry.

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

  • Resolves #{issue number}

@brookslogan brookslogan requested a review from nmdefries May 22, 2025 16:44
@brookslogan
Copy link
Contributor Author

/style

@brookslogan brookslogan changed the title perf: fix temp key in filter.epi_archive that has to be reset Fix temporary key setting in filter.epi_archive that has to be reset May 28, 2025
@brookslogan
Copy link
Contributor Author

This seems like a straightforward fix, and it addresses potential warnings that might start cropping up in other PRs. Just going to merge.

@brookslogan brookslogan merged commit e91bdf8 into dev May 28, 2025
3 checks passed
@dshemetov dshemetov deleted the lcb/archive-filter-proper-intermediate-key branch May 28, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant