Fix temporary key setting in filter.epi_archive
that has to be reset
#669
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please:
PR).
brookslogan, nmdefries.
DESCRIPTION
. Always incrementthe patch version number (the third number), unless you are making a
release PR from dev to main, in which case increment the minor version
number (the second number).
(backwards-incompatible changes to the documented interface) are noted.
Collect the changes under the next release number (e.g. if you are on
1.7.2, then write your changes under the 1.8 heading).
/document
to check the package documentation and fix any issues./style
to check the style and fix any issues./preview-docs
to preview the docs.process.
Change explanations for reviewer
filter.epi_archive
sets adata.table
's key before feeding it intonew_epi_archive
, thinking that / planning fornew_epi_archive
to require the key to already be set properly. But it did it improperly. Thankfully,new_epi_archive
actually just does a second round of sorting if required. There are some warnings in some versions ofdata.table
in some cases from the bogus intermediate key.The archive key ordering is still a bit weird... I thought I already completed most of the geo-time-other[-version] --> geo-other-time[-version] changes, but apparently not. Not adjusting this now because example data sets need checked.
Don't think this is worth a version bump or changelog entry.
Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch