Merge pull request #153751 from cockroachdb/blathers/backport-release-24.1-153682

release-24.1: docgen: update ALTER {INDEX,TABLE} SCATTER diagram

Author: rafiss

docs/generated/sql/bnf/alter_index.bnf

@@ -19,6 +19,7 @@ alter_index_stmt ::=
 	| 'ALTER' 'INDEX' index_name 'UNSPLIT' 'AT' select_stmt
 	| 'ALTER' 'INDEX' table_name '@' index_name 'UNSPLIT' 'ALL'
 	| 'ALTER' 'INDEX' index_name 'UNSPLIT' 'ALL'
+	| alter_scatter_index_stmt
 	| 'ALTER' 'INDEX' table_name '@' index_name 'RENAME' 'TO' index_new_name
 	| 'ALTER' 'INDEX' index_name 'RENAME' 'TO' index_new_name
 	| 'ALTER' 'INDEX' 'IF' 'EXISTS' table_name '@' index_name 'RENAME' 'TO' index_new_name

docs/generated/sql/bnf/alter_table.bnf

@@ -5,6 +5,7 @@ alter_table_stmt ::=
 	| 'ALTER' 'TABLE' table_name 'SPLIT' 'AT' select_stmt 'WITH' 'EXPIRATION' a_expr
 	| 'ALTER' 'TABLE' table_name 'UNSPLIT' 'AT' select_stmt
 	| 'ALTER' 'TABLE' table_name 'UNSPLIT' 'ALL'
+	| alter_scatter_stmt
 	| 'ALTER' 'TABLE' table_name 'CONFIGURE' 'ZONE' 'USING' variable '=' 'COPY' 'FROM' 'PARENT' ( ( ',' variable '=' value | ',' variable '=' 'COPY' 'FROM' 'PARENT' ) )*
 	| 'ALTER' 'TABLE' table_name 'CONFIGURE' 'ZONE' 'USING' variable '=' value ( ( ',' variable '=' value | ',' variable '=' 'COPY' 'FROM' 'PARENT' ) )*
 	| 'ALTER' 'TABLE' table_name 'CONFIGURE' 'ZONE' 'DISCARD'

pkg/cmd/docgen/diagrams.go

@@ -419,7 +419,6 @@ var specs = []stmtSpec{
 		name:    "alter_index",
 		stmt:    "alter_index_stmt",
 		inline:  []string{"alter_oneindex_stmt", "alter_index_cmds", "alter_index_cmd", "partition_by_index", "partition_by_inner", "partition_by", "table_index_name", "alter_split_index_stmt", "alter_unsplit_index_stmt", "alter_rename_index_stmt", "alter_zone_index_stmt", "var_set_list", "alter_index_visible_stmt", "set_zone_config", "alter_index_visible"},
-		exclude: []*regexp.Regexp{regexp.MustCompile("alter_scatter_index_stmt")},
 		replace: map[string]string{"standalone_index_name": "index_name", "var_name": "variable", "var_value": "value", "'RENAME' 'TO' index_name": "'RENAME' 'TO' index_new_name"},
 		unlink:  []string{"index_new_name", "variable", "value"},
 	},
@@ -547,7 +546,6 @@ var specs = []stmtSpec{
 		name:    "alter_table",
 		stmt:    "alter_table_stmt",
 		inline:  []string{"alter_onetable_stmt", "alter_table_cmds", "alter_split_stmt", "alter_unsplit_stmt", "alter_zone_table_stmt", "alter_rename_table_stmt", "alter_table_set_schema_stmt", "alter_table_locality_stmt", "alter_table_owner_stmt", "set_zone_config", "var_set_list"},
-		exclude: []*regexp.Regexp{regexp.MustCompile("alter_scatter_stmt")},
 		replace: map[string]string{"relation_expr": "table_name", "'RENAME' 'TO' table_name": "'RENAME' 'TO' table_new_name", "var_name": "variable", "var_value": "value"},
 		unlink:  []string{"table_name", "table_new_name", "variable", "value"},
 	},