catkinization?

[airballking]

This is still a rosbuild package. Does it make sense to catkinize this? It looks like it's build some prolog code and depends on a package ias_knowledge base. So I cannot really judge what's going on and the state..

[mtenorth]

As I'm currently catkinizin the knowrob_addons packages and some of them depend on this, I'm in favour of catkinizing it.

However, I'd also recommend to refactor this package in order to separate the Gazebo parts from the URDF parts and the OWL description in order to avoid an explosion of dependencies.

[airballking]

OK. Catkinization it is, then!

Refactoring also sounds good. This is already a single repo, and we could split it in place.. Shall we sit together and make a list of TODOs?

Update:

• compilation only prolog/owl-stuff --> will become obsolete once knowrob has been catkinized
• rest seems to be various urdf/gazebo/meshes/2d-map data --> need for consolidation
• urdf of kitchen seems redundant with semantic map --> can we purge parts of this?

[mtenorth]

@fairlight1337 : What do you think regarding this? Would you agree with splitting up this package? How about the Gazebo files, are they still up to date?

[fairlight1337]

Hey,

I didn't know the URDF parts were still in the repo. I thought I remove them at some point, but if they are there, I think you can safely split that. They aren't necessary for the robot specific stuff we're doing.

So, all in favor of the above!

On 31.07.2014, at 16:15, Moritz Tenorth [email protected] wrote:

@fairlight1337 : What do you think regarding this? Would you agree with splitting up this package? How about the Gazebo files, are they still up to date?

—
Reply to this email directly or view it on GitHub.

[mtenorth]

Updates: CRAM can still load the semantic map from the updated KnowRob + iai_maps, launched using the 'json.launch' file in iai_maps, as before. I've created a tag 'rosbuild' in case you'd like to go back to the old version.

So I'd propose to merge the pull request and either switch to the 'rosbuild' tag or the new KnowRob. What do you think?

[fairlight1337]

All in favour of merging. Any other objections?
If not, I'll merge it after lunch today (if nobody beat me to it ;) )

[gaya-]

Is there anything open left in this issue?

[gaya-]

Fixedi in 2f29098.