Skip to content

Commit e64fd55

Browse files
committed
[Flight] Encode ReactIOInfo as its own row type (facebook#33390)
Stacked on facebook#33388. This encodes the I/O entries as their own row type (`"J"`). This makes it possible to parse them directly without first parsing the debug info for each component. E.g. if you're just interested in logging the I/O without all the places it was awaited. This is not strictly necessary since the debug info is also readily available without parsing the actual trees. (That's how the Server Components Performance Track works.) However, we might want to exclude this information in profiling builds while retaining some limited form of I/O tracking. It also allows for logging side-effects that are not awaited if we wanted to. DiffTrain build for [3fb17d1](facebook@3fb17d1)
1 parent c35ca14 commit e64fd55

37 files changed

+209
-233
lines changed

compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
4a1f29079ccc61659e026bbcf205bc8d53780927
1+
3fb17d16a4838e132d0d6dbb08f91b7e7da691eb
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
4a1f29079ccc61659e026bbcf205bc8d53780927
1+
3fb17d16a4838e132d0d6dbb08f91b7e7da691eb

compiled/facebook-www/React-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1537,7 +1537,7 @@ __DEV__ &&
15371537
exports.useTransition = function () {
15381538
return resolveDispatcher().useTransition();
15391539
};
1540-
exports.version = "19.2.0-www-classic-4a1f2907-20250602";
1540+
exports.version = "19.2.0-www-classic-3fb17d16-20250603";
15411541
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
15421542
"function" ===
15431543
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1537,7 +1537,7 @@ __DEV__ &&
15371537
exports.useTransition = function () {
15381538
return resolveDispatcher().useTransition();
15391539
};
1540-
exports.version = "19.2.0-www-modern-4a1f2907-20250602";
1540+
exports.version = "19.2.0-www-modern-3fb17d16-20250603";
15411541
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
15421542
"function" ===
15431543
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-prod.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -635,4 +635,4 @@ exports.useSyncExternalStore = function (
635635
exports.useTransition = function () {
636636
return ReactSharedInternals.H.useTransition();
637637
};
638-
exports.version = "19.2.0-www-classic-4a1f2907-20250602";
638+
exports.version = "19.2.0-www-classic-3fb17d16-20250603";

compiled/facebook-www/React-prod.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -635,4 +635,4 @@ exports.useSyncExternalStore = function (
635635
exports.useTransition = function () {
636636
return ReactSharedInternals.H.useTransition();
637637
};
638-
exports.version = "19.2.0-www-modern-4a1f2907-20250602";
638+
exports.version = "19.2.0-www-modern-3fb17d16-20250603";

compiled/facebook-www/React-profiling.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -639,7 +639,7 @@ exports.useSyncExternalStore = function (
639639
exports.useTransition = function () {
640640
return ReactSharedInternals.H.useTransition();
641641
};
642-
exports.version = "19.2.0-www-classic-4a1f2907-20250602";
642+
exports.version = "19.2.0-www-classic-3fb17d16-20250603";
643643
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
644644
"function" ===
645645
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-profiling.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -639,7 +639,7 @@ exports.useSyncExternalStore = function (
639639
exports.useTransition = function () {
640640
return ReactSharedInternals.H.useTransition();
641641
};
642-
exports.version = "19.2.0-www-modern-4a1f2907-20250602";
642+
exports.version = "19.2.0-www-modern-3fb17d16-20250603";
643643
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
644644
"function" ===
645645
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.classic.js

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1080,7 +1080,7 @@ __DEV__ &&
10801080
if (null !== instance.autoName) return instance.autoName;
10811081
props = pendingEffectsRoot.identifierPrefix;
10821082
var globalClientId = globalClientIdCounter$1++;
1083-
props = "\u00ab" + props + "t" + globalClientId.toString(32) + "\u00bb";
1083+
props = "_" + props + "t_" + globalClientId.toString(32) + "_";
10841084
return (instance.autoName = props);
10851085
}
10861086
function getClassNameByType(classByType) {
@@ -6122,11 +6122,7 @@ __DEV__ &&
61226122
identifierPrefix = workInProgressRoot.identifierPrefix,
61236123
globalClientId = globalClientIdCounter++;
61246124
identifierPrefix =
6125-
"\u00ab" +
6126-
identifierPrefix +
6127-
"r" +
6128-
globalClientId.toString(32) +
6129-
"\u00bb";
6125+
"_" + identifierPrefix + "r_" + globalClientId.toString(32) + "_";
61306126
return (hook.memoizedState = identifierPrefix);
61316127
}
61326128
function mountRefresh() {
@@ -19080,10 +19076,10 @@ __DEV__ &&
1908019076
(function () {
1908119077
var internals = {
1908219078
bundleType: 1,
19083-
version: "19.2.0-www-classic-4a1f2907-20250602",
19079+
version: "19.2.0-www-classic-3fb17d16-20250603",
1908419080
rendererPackageName: "react-art",
1908519081
currentDispatcherRef: ReactSharedInternals,
19086-
reconcilerVersion: "19.2.0-www-classic-4a1f2907-20250602"
19082+
reconcilerVersion: "19.2.0-www-classic-3fb17d16-20250603"
1908719083
};
1908819084
internals.overrideHookState = overrideHookState;
1908919085
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -19117,7 +19113,7 @@ __DEV__ &&
1911719113
exports.Shape = Shape;
1911819114
exports.Surface = Surface;
1911919115
exports.Text = Text;
19120-
exports.version = "19.2.0-www-classic-4a1f2907-20250602";
19116+
exports.version = "19.2.0-www-classic-3fb17d16-20250603";
1912119117
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1912219118
"function" ===
1912319119
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.modern.js

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -986,7 +986,7 @@ __DEV__ &&
986986
if (null !== instance.autoName) return instance.autoName;
987987
props = pendingEffectsRoot.identifierPrefix;
988988
var globalClientId = globalClientIdCounter$1++;
989-
props = "\u00ab" + props + "t" + globalClientId.toString(32) + "\u00bb";
989+
props = "_" + props + "t_" + globalClientId.toString(32) + "_";
990990
return (instance.autoName = props);
991991
}
992992
function getClassNameByType(classByType) {
@@ -6028,11 +6028,7 @@ __DEV__ &&
60286028
identifierPrefix = workInProgressRoot.identifierPrefix,
60296029
globalClientId = globalClientIdCounter++;
60306030
identifierPrefix =
6031-
"\u00ab" +
6032-
identifierPrefix +
6033-
"r" +
6034-
globalClientId.toString(32) +
6035-
"\u00bb";
6031+
"_" + identifierPrefix + "r_" + globalClientId.toString(32) + "_";
60366032
return (hook.memoizedState = identifierPrefix);
60376033
}
60386034
function mountRefresh() {
@@ -18852,10 +18848,10 @@ __DEV__ &&
1885218848
(function () {
1885318849
var internals = {
1885418850
bundleType: 1,
18855-
version: "19.2.0-www-modern-4a1f2907-20250602",
18851+
version: "19.2.0-www-modern-3fb17d16-20250603",
1885618852
rendererPackageName: "react-art",
1885718853
currentDispatcherRef: ReactSharedInternals,
18858-
reconcilerVersion: "19.2.0-www-modern-4a1f2907-20250602"
18854+
reconcilerVersion: "19.2.0-www-modern-3fb17d16-20250603"
1885918855
};
1886018856
internals.overrideHookState = overrideHookState;
1886118857
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -18889,7 +18885,7 @@ __DEV__ &&
1888918885
exports.Shape = Shape;
1889018886
exports.Surface = Surface;
1889118887
exports.Text = Text;
18892-
exports.version = "19.2.0-www-modern-4a1f2907-20250602";
18888+
exports.version = "19.2.0-www-modern-3fb17d16-20250603";
1889318889
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1889418890
"function" ===
1889518891
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)