fix: add some checks on benchmark find one

Author: Mikadows

src/benchmarks/benchmark.controller.ts

@@ -42,8 +42,8 @@ export class BenchmarkController {
   @ApiOkResponse({ type: Benchmark, description: 'Requested benchmark' })
   @Get(':id')
   async getBenchmarkById(
-    @Param() id: BenchmarkIdDto,
+    @Param() benchmarkIdDto: BenchmarkIdDto,
   ): Promise<Benchmark | undefined> {
-    return this.benchmarkService.findOne(id);
+    return this.benchmarkService.findOne(benchmarkIdDto.id);
   }
 }

src/benchmarks/benchmark.service.ts

@@ -1,6 +1,7 @@
-import { Injectable } from '@nestjs/common';
+import { BadRequestException, Injectable } from '@nestjs/common';
 import { Repository } from 'typeorm';
 import { InjectRepository } from '@nestjs/typeorm';
+import { isUUID } from 'class-validator';
 import { CreateBenchmarkDto } from './dto/create-benchmark.dto';
 import { Benchmark } from './benchmark.entity';
 import { User } from '../users/user.entity';
@@ -25,7 +26,16 @@ export class BenchmarkService {
     return this.benchmarkRepository.find({});
   }
 
-  async findOne(id: { id: string }): Promise<Benchmark | undefined> {
-    return this.benchmarkRepository.findOne(id);
+  async findOne(id: string): Promise<Benchmark | undefined> {
+    if (!isUUID(id)) {
+      throw new BadRequestException(`Invalid benchmark id: ${id}`);
+    }
+    const benchmark = await this.benchmarkRepository.findOne(id);
+
+    if (!benchmark) {
+      throw new BadRequestException(`Could not find benchmark: ${id}`);
+    }
+
+    return benchmark;
   }
 }