chore: cleanup & comments

Author: angristan

options.go

@@ -18,8 +18,7 @@ func getFirecrackerConfig(vmmID string) (firecracker.Config, error) {
 		KernelImagePath: "../../linux/vmlinux",
 		LogPath:         fmt.Sprintf("%s.log", socket),
 		Drives: []models.Drive{{
-			DriveID: firecracker.String("1"),
-			// TODO: copy base rootfs and use a temp roots per VM
+			DriveID:      firecracker.String("1"),
 			PathOnHost:   firecracker.String("/tmp/rootfs-" + vmmID + ".ext4"),
 			IsRootDevice: firecracker.Bool(true),
 			IsReadOnly:   firecracker.Bool(false),

pool.go

@@ -20,15 +20,22 @@ func fillVMPool(ctx context.Context, WarmVMs chan<- runningFirecracker) {
 				time.Sleep(time.Second)
 				continue
 			}
+
 			log.WithField("ip", vm.ip).Info("New VM created and started")
+
+			// Don't wait forever, if the VM is not available after 10s, move on
 			ctx, cancel := context.WithTimeout(ctx, 10*time.Second)
 			defer cancel()
+
 			err = waitForVMToBoot(ctx, vm.ip)
 			if err != nil {
 				log.WithError(err).Info("VM not ready yet")
 				vm.vmmCancel()
 				continue
 			}
+
+			// Add the new microVM to the pool.
+			// If the pool is full, this line will block until a slot is available.
 			WarmVMs <- *vm
 		}
 	}