Merge pull request angular-ui#353 from angular-ui/fix-choices-lesswatches

fix(choices): prevent unnecessary watches when dropdown is closed

Author: dimirc

src/select.js

@@ -885,6 +885,7 @@
           }
 
           choices.attr('ng-repeat', RepeatParser.getNgRepeatExpression($select.parserResult.itemName, '$select.items', $select.parserResult.trackByExp, groupByExp))
+              .attr('ng-if', '$select.open') //Prevent unnecessary watches when dropdown is closed
               .attr('ng-mouseenter', '$select.setActiveItem('+$select.parserResult.itemName +')')
               .attr('ng-click', '$select.select(' + $select.parserResult.itemName + ')');
 

test/select.spec.js

@@ -144,6 +144,7 @@ describe('ui-select tests', function() {
     var choicesContainerEl = $(el).find('.ui-select-choices');
     expect(choicesContainerEl.length).toEqual(1);
 
+    openDropdown(el);
     var choicesEls = $(el).find('.ui-select-choices-row');
     expect(choicesEls.length).toEqual(8);
   });
@@ -367,12 +368,14 @@ describe('ui-select tests', function() {
       });
 
       it('should set a disabled class on the option', function() {
-        var option = $(this.el).find('.ui-select-choices-row div:contains("Wladimir")');
-        var container = option.closest('.ui-select-choices-row');
 
         openDropdown(this.el);
 
+        var option = $(this.el).find('.ui-select-choices-row div:contains("Wladimir")');
+        var container = option.closest('.ui-select-choices-row');
+
         expect(container.hasClass('disabled')).toBeTruthy();
+
       });
     });
 
@@ -398,11 +401,11 @@ describe('ui-select tests', function() {
       });
 
       it('should set a disabled class on the option', function() {
+        openDropdown(this.el);
+
         var option = $(this.el).find('.ui-select-choices-row div:contains("Wladimir")');
         var container = option.closest('.ui-select-choices-row');
 
-        openDropdown(this.el);
-
         expect(container.hasClass('disabled')).toBeTruthy();
       });
     });
@@ -429,11 +432,11 @@ describe('ui-select tests', function() {
       });
 
       it('should set a disabled class on the option', function() {
+        openDropdown(this.el);
+
         var option = $(this.el).find('.ui-select-choices-row div:contains("Wladimir")');
         var container = option.closest('.ui-select-choices-row');
 
-        openDropdown(this.el);
-
         expect(container.hasClass('disabled')).toBeTruthy();
       });
     });
@@ -485,9 +488,8 @@ describe('ui-select tests', function() {
       var el = createUiSelect();
       el.scope().$select.search = 't';
       scope.$digest();
-      var choices = el.find('.ui-select-choices-row');
-
       openDropdown(el);
+      var choices = el.find('.ui-select-choices-row');
 
       expect(choices.eq(0)).toHaveClass('active');
       expect(getGroupLabel(choices.eq(0)).text()).toBe('Foo');
@@ -844,6 +846,7 @@ describe('ui-select tests', function() {
       </ui-select>'
     );
 
+    openDropdown(el);
     expect($(el).find('.only-once').length).toEqual(1);