Merge pull request #251 from codeoverflow-org/remove-configless-schemas

Remove JSON schemas from configuration-less services

Author: hlxid

nodecg-io-core/extension/serviceBundle.ts

@@ -108,6 +108,8 @@ export abstract class ServiceBundle<R, C> implements Service<R, C> {
     requiresNoConfig = false;
 
     private readSchema(pathSegments: string[]): ObjectMap<unknown> | undefined {
+        if (pathSegments.length === 0) return undefined;
+
         const joinedPath = path.resolve(...pathSegments);
         try {
             const fileContent = fs.readFileSync(joinedPath, "utf8");

nodecg-io-curseforge/extension/index.ts

@@ -36,11 +36,11 @@ export {
 } from "./curseforgeClient";
 
 module.exports = (nodecg: NodeCG) => {
-    new CurseforgeService(nodecg, "curseforge", __dirname, "../schema.json").register();
+    new CurseforgeService(nodecg, "curseforge").register();
 };
 
 class CurseforgeService extends ServiceBundle<never, CurseForgeClient> {
-    async validateConfig(_: never): Promise<Result<void>> {
+    async validateConfig(): Promise<Result<void>> {
         return emptySuccess();
     }
 

nodecg-io-curseforge/schema.json

@@ -2,22 +2,18 @@ import { NodeCG } from "nodecg-types/types/server";
 import { Result, emptySuccess, success, ServiceBundle } from "nodecg-io-core";
 import { DebugHelper } from "./debugHelper";
 
-export type DebugConfig = {
-    // Nothing to configure
-};
-
 export { DebugHelper } from "./debugHelper";
 
 module.exports = (nodecg: NodeCG) => {
-    new DebugService(nodecg, "debug", __dirname, "../schema.json").register();
+    new DebugService(nodecg, "debug").register();
 };
 
-class DebugService extends ServiceBundle<DebugConfig, DebugHelper> {
-    async validateConfig(_: DebugConfig): Promise<Result<void>> {
+class DebugService extends ServiceBundle<never, DebugHelper> {
+    async validateConfig(): Promise<Result<void>> {
         return emptySuccess();
     }
 
-    async createClient(_: DebugConfig): Promise<Result<DebugHelper>> {
+    async createClient(): Promise<Result<DebugHelper>> {
         const client = DebugHelper.createClient(this.nodecg);
         this.nodecg.log.info("Successfully created debug helper.");
         return success(client);