Skip to content
This repository was archived by the owner on Apr 13, 2025. It is now read-only.

Commit d08d7a4

Browse files
authored
Move nodecg-types to be a dev dependency everywhere (#764)
`nodecg-types` is only used when compiling typescript at dev time and not required when running nodecg-io. This PR moves it to be a dev dependency everywhere because it was mistakenly a prod dependency in some bundles.
1 parent 74586c2 commit d08d7a4

File tree

4 files changed

+14
-14
lines changed

4 files changed

+14
-14
lines changed

nodecg-io-core/dashboard/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,12 @@
2121
"devDependencies": {
2222
"esbuild": "^0.15.6",
2323
"monaco-editor": "^0.34.0",
24+
"nodecg-types": "^1.9.0",
2425
"typescript": "^4.8.2"
2526
},
2627
"dependencies": {
2728
"crypto-js": "^4.1.1",
2829
"nodecg-io-core": "^0.3.0",
29-
"nodecg-types": "^1.9.0",
3030
"events": "^3.3.0"
3131
},
3232
"license": "MIT"

package-lock.json

Lines changed: 8 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

services/nodecg-io-debug/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,12 +49,12 @@
4949
"devDependencies": {
5050
"@types/node": "^18.7.14",
5151
"esbuild": "^0.15.6",
52-
"nodecg-io-tsconfig": "^1.0.0",
5352
"monaco-editor": "^0.34.0",
53+
"nodecg-io-tsconfig": "^1.0.0",
54+
"nodecg-types": "^1.9.0",
5455
"typescript": "^4.8.2"
5556
},
5657
"dependencies": {
57-
"nodecg-io-core": "^0.3.0",
58-
"nodecg-types": "^1.9.0"
58+
"nodecg-io-core": "^0.3.0"
5959
}
6060
}

services/nodecg-io-nanoleaf/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,12 @@
3232
"devDependencies": {
3333
"@types/node": "^18.7.14",
3434
"nodecg-io-tsconfig": "^1.0.0",
35+
"nodecg-types": "^1.9.0",
3536
"typescript": "^4.8.2"
3637
},
3738
"dependencies": {
3839
"@types/node-fetch": "^2.6.1",
3940
"node-fetch": "^2.6.7",
40-
"nodecg-io-core": "^0.3.0",
41-
"nodecg-types": "^1.9.0"
41+
"nodecg-io-core": "^0.3.0"
4242
}
4343
}

0 commit comments

Comments
 (0)