Skip to content

[dev]: add homebrew job to publish.yaml #2841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jsjoeio opened this issue Mar 8, 2021 · 0 comments · Fixed by #3010
Closed

[dev]: add homebrew job to publish.yaml #2841

jsjoeio opened this issue Mar 8, 2021 · 0 comments · Fixed by #3010
Assignees
Labels
chore Related to maintenance or clean up ci Issues related to ci enhancement Some improvement that isn't a feature
Milestone

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Mar 8, 2021

Problem

After we publish a release, we have to manually run a command to update the homebrew code-server package. This should be automated as part of the release process.

Solution

Add a job called homebrew to publish.yaml that waits on npm and then updates code-server on homebrew with bump-formula-pr

Notes

  • the script would run brew bump-formula-pr --version=3.9.1 code-server --no-browse
  • it may need a GITHUB_TOKEN or something. it would have to open the PR on behalf of someone I think (maybe person who merges PR for release?)
    • probably a security risk here. asher suggested using a bot or something (maybe the cdr bot?)
  • the --no-browse flag ensures it doesn't try to open the PR in the browser
  • it would have to grab the version from somewhere. maybe we could do a cURL call to the npm API? maybe there's something easier.
  • see bump-formula-pr docs here
  • look at this PR which added something similar for coder: Add workflow for bumping version homebrew-coder#8
@jsjoeio jsjoeio added enhancement Some improvement that isn't a feature help-wanted labels Mar 8, 2021
@jsjoeio jsjoeio added this to the v3.9.3 milestone Mar 25, 2021
@jsjoeio jsjoeio self-assigned this Mar 31, 2021
@jsjoeio jsjoeio added ci Issues related to ci and removed help-wanted labels Mar 31, 2021
@jsjoeio jsjoeio linked a pull request Mar 31, 2021 that will close this issue
1 task
@jsjoeio jsjoeio added the chore Related to maintenance or clean up label May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to maintenance or clean up ci Issues related to ci enhancement Some improvement that isn't a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant