feat: add remote directory picker to file sync #73
Conversation
Adds a new remote directory picker window used when creating a file sync to select the remote directory.
|
It's ready for review, just need to finish the few TODOs |
| @@ -1,7 +1,6 @@ | |||
| using System.Diagnostics; | |||
| using Coder.Desktop.App.Models; | |||
| using Coder.Desktop.App.Services; | |||
There was a problem hiding this comment.
| using Coder.Desktop.App.Services; | |
| using Coder.Desktop.App.Services; | |
| using Coder.Desktop.CoderSdk.Coder; |
|
|
||
| private readonly ISyncSessionController _syncSessionController; | ||
| private readonly IRpcController _rpcController; | ||
| private readonly ICredentialManager _credentialManager; | ||
| private readonly IAgentApiClientFactory _agentApiClientFactory; |
There was a problem hiding this comment.
This doesn't smell right to me---this is not a direct dependency of the FileSyncListViewModel, it's a dependency of the directory picker. Shouldn't we be using dependency injection to resolve the dependency at the time the directory picker is created, not the time time file sync list is created?
| { | ||
| new() | ||
| { | ||
| Name = "(root)", |
There was a problem hiding this comment.
In the Windows native file explorer, this is rendered as "🖥️ This PC" --- I think just 🖥️ would look a little more friendly and nice than (root).
| TextTrimming="CharacterEllipsis" | ||
| IsTextTrimmedChanged="TooltipText_IsTextTrimmedChanged" | ||
| Margin="0,0,0,10" /> | ||
| <ProgressRing |
| [RelayCommand] | ||
| private void StartCreatingNewSession() | ||
| { | ||
| ClearNewForm(); | ||
| // Ensure we have a fresh hosts list before we open the form. | ||
| SetAvailableHostsFromRpcModel(_rpcController.GetState()); |
There was a problem hiding this comment.
It might be a little annoying to find that the available hosts only updates when you click the button to create a new session. I could imagine starting up a workspace, then creating a new session to find your workspace isn't yet listed. To get it to populate you need to cancel out, then wait for it to start, maybe by watching the tray menu, then create a new sync session.
| @@ -534,25 +538,44 @@ private void StartDaemonProcess() | |||
| Directory.CreateDirectory(_mutagenDataDirectory); | |||
| var logPath = Path.Combine(_mutagenDataDirectory, "daemon.log"); | |||
| var logStream = new StreamWriter(logPath, true); | |||
| try | |||
There was a problem hiding this comment.
Can you refactor this into a separate PR? It doesn't have anything to do with the remote picker.
| _daemonProcess?.Dispose(); | ||
| _logWriter?.Dispose(); | ||
| _daemonProcess = null; | ||
| _logWriter = null; |
There was a problem hiding this comment.
If we throw an exception starting the daemon, the logStream never gets turned into _logWriter and will leave open the logfile, which makes retries fail.
Adds a new remote directory picker window used when creating a file sync to select the remote directory.
NVIDIA_Overlay_LplyNOug3n.mp4
TODOs:
Closes #27