Skip to content

Why cz-conventional-changelog is not the default adapter? #762

@felipecrs

Description

@felipecrs
Contributor

I believe it's the most used since it's the one that best complies with conventionalcommits.org.

Activity

jimthedev

jimthedev commented on Aug 31, 2020

@jimthedev
Member

I would be ok with it being the default. The reason for it not being the default is that this was created before conventionalcommits.org existed so we didn't really know what convention would "win". I would be ok with a major version that makes it the default when initializing. I think it would be a good change so long as we still allow for people to define alternative adapters.

felipecrs

felipecrs commented on Sep 14, 2020

@felipecrs
ContributorAuthor

@dmwelch should I open a new issue for proposing this change?

dmwelch

dmwelch commented on Sep 14, 2020

@dmwelch
Contributor

Sorry, I was thinking this would go into the development backlog for the next major release. I'll reopen it and tag it as such.

added this to the 5.0.0 milestone on Sep 14, 2020
felipecrs

felipecrs commented on Sep 14, 2020

@felipecrs
ContributorAuthor

Okay, I just found that cz-conventional-changelog is already the default adapter. The problem with:

If your repo is NOT Commitizen friendly:

If you're not working in a Commitizen friendly repository, then git cz will work just the same as git commit but npx cz will use the streamich/git-cz adapter. To fix this, you need to first make your repo Commitizen-friendly

Is that:

  1. npx cz was used to be npx git-cz, and git-cz on NPM points to streamich's.
  2. $ npx cz
    command not found: cz
  3. Instead of falling back to the normal git commit, we should proceed using the default adapter.
commitizen-bot

commitizen-bot commented on Oct 20, 2020

@commitizen-bot

🎉 This issue has been resolved in version 4.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

added a commit that references this issue on Oct 22, 2020
9b7832b
added a commit that references this issue on Jan 18, 2021
6574ec9
added a commit that references this issue on Mar 4, 2021
1e8a677
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

    Participants

    @jimthedev@dmwelch@commitizen-bot@felipecrs

    Issue actions

      Why cz-conventional-changelog is not the default adapter? · Issue #762 · commitizen/cz-cli