Skip to content

Initializes job assuming Docker is available, still tries to run it if not #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tetron opened this issue Feb 24, 2017 · 2 comments
Open

Comments

@tetron
Copy link
Member

tetron commented Feb 24, 2017

When setting up the job, paths are different depending on whether it will run inside a container or outside.

In CommandLineJob.run, if running in Docker is not available (docker.get_from_requirements returns None) it will try to run the job without Docker. However, because the job was already set up assuming Docker, this doesn't work.

@mr-c
Copy link
Member

mr-c commented Feb 25, 2017

This is the root cause of #281 and #213

@kapilkd13
Copy link
Contributor

I think one way to solve this problem is to check if Docker is available even before setting paths in Job. What do you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants