Skip to content

cwltool enumerates every single file and folder in the output directory, unneccesarily #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mr-c opened this issue Nov 10, 2017 · 4 comments

Comments

@mr-c
Copy link
Member

mr-c commented Nov 10, 2017

for root, dirs, files in os.walk(outdir):

To reproduce: run cwltool --outdir ${HOME} and a simple CWL description on real user's system

Perhaps a single temporary folder should be created within outdir where the intermediate output directories are then stored under? That way this loop would iterate over just that single folder instead of walking the entire tree from outdir.

@esanzgar
Copy link

esanzgar commented Aug 1, 2018

Are you sure is that line that causes the issue?

I believe it might be this other:

for root, dirs, files in os.walk(outdir):

This code needs urgent revision, it causes a huge performance penalty.

@mr-c
Copy link
Member Author

mr-c commented Aug 1, 2018

@esanzgar you are correct, I didn't use a permalink so the line numbers shifted. I've updated the issue, thanks!

@psafont
Copy link
Contributor

psafont commented Aug 1, 2018

Work happening on #850

@psafont
Copy link
Contributor

psafont commented Nov 7, 2018

Solved with #926

@psafont psafont closed this as completed Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants